third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in - Issue 2257743002: Restore user state on ReloadwithoutSubResourceCacheRevalidation

Side by Side Diff: third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Issue 2257743002: Restore user state on ReloadwithoutSubResourceCacheRevalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: plumb a runtime flag Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java ('K') | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | third_party/WebKit/Source/web/WebRuntimeFeatures.cpp » ('j') | third_party/WebKit/public/web/WebRuntimeFeatures.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // http://dev.chromium.org/blink/runtime-enabled-features	1 // http://dev.chromium.org/blink/runtime-enabled-features

2 //	2 //

3 // This list is used to generate RuntimeEnabledFeatures.h/cpp which contains	3 // This list is used to generate RuntimeEnabledFeatures.h/cpp which contains

4 // a class that stores static enablers for all experimental features.	4 // a class that stores static enablers for all experimental features.

5 //	5 //

6 // Each feature can be assigned a "status":	6 // Each feature can be assigned a "status":

7 // status=stable -> Enable this in all Blink configurations. We are committed t o these APIs indefinitely.	7 // status=stable -> Enable this in all Blink configurations. We are committed t o these APIs indefinitely.

8 // status=experimental -> In-progress features, Web Developers might play with, but are not on by default in stable.	8 // status=experimental -> In-progress features, Web Developers might play with, but are not on by default in stable.

9 // status=test -> Enabled in ContentShell for testing, otherwise off.	9 // status=test -> Enabled in ContentShell for testing, otherwise off.

10 // Features without a status are not enabled anywhere by default.	10 // Features without a status are not enabled anywhere by default.

(...skipping 112 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
123 MediaDocumentDownloadButton	123 MediaDocumentDownloadButton

124 MediaGetSettings status=test	124 MediaGetSettings status=test

125 MediaSession	125 MediaSession

126 MediaSourceExperimental status=experimental	126 MediaSourceExperimental status=experimental

127 MediaSourceNewAbortAndDuration status=experimental	127 MediaSourceNewAbortAndDuration status=experimental

128 MediaStreamSpeech status=experimental	128 MediaStreamSpeech status=experimental

129 MemoryInfoInWorkers status=experimental	129 MemoryInfoInWorkers status=experimental

130 MobileLayoutTheme	130 MobileLayoutTheme

131 ModuleScripts status=test	131 ModuleScripts status=test

132 NavigatorContentUtils	132 NavigatorContentUtils

	133 NonValidatingReload
	tkent 2016/08/30 06:42:06 -> NonValidatingReloadOnNormalReload -> NonValidatingReloadOnNormalReload Takashi Toyoshima 2016/08/31 05:57:02 I have some thoughts about this. Chrome has two f I have some thoughts about this. Chrome has two feature flags around NonValidatingReload. One is NonValidatingReloadOnRefreshContent, the other is NonValidatingReloadOnNormalReload. They means a flag to enable NonValidatingReload against RefreshContent UI, and a flag to enable NonValidatingReload against NormalReload UI. Since Blink should not be aware of such embedder side user actions that triggers the feature, I chose NonValidatingReload for this flag name. Probably, I should also flip this flag for NonValidatingReloadOnRefreshContent. But checking the field study flags has complicated side effects and I need to be too careful to enable a Blink feature for two field trial flags to be statically correct. Here OnRefreshContent case does not matter so important. That's why I just ignore OnRefreshContent cases as a practical solution. Does this make sense? I do not stick this name, but I'd hear your opinion about this background. tkent 2016/08/31 06:30:33 Ok, I understand you'd like to add a Blink flag di Show quoted text On 2016/08/31 at 05:57:02, toyoshim wrote: > I have some thoughts about this. > > Chrome has two feature flags around NonValidatingReload. > One is NonValidatingReloadOnRefreshContent, the other is NonValidatingReloadOnNormalReload. > They means a flag to enable NonValidatingReload against RefreshContent UI, and a flag to enable NonValidatingReload against NormalReload UI. > > Since Blink should not be aware of such embedder side user actions that triggers the feature, I chose NonValidatingReload for this flag name. > > Probably, I should also flip this flag for NonValidatingReloadOnRefreshContent. But checking the field study flags has complicated side effects and I need to be too careful to enable a Blink feature for two field trial flags to be statically correct. Here OnRefreshContent case does not matter so important. That's why I just ignore OnRefreshContent cases as a practical solution. > > Does this make sense? I do not stick this name, but I'd hear your opinion about this background. Ok, I understand you'd like to add a Blink flag different from the Chromium flags. However, the flag name 'NonValidatingReload' is still unclear. I haven't seen the word 'validate' in the Blink loader area. What is (not) validated in this context? tkent 2016/08/31 06:32:44 cache validation? Show quoted text On 2016/08/31 at 06:30:33, tkent wrote: > Ok, I understand you'd like to add a Blink flag different from the Chromium flags. > However, the flag name 'NonValidatingReload' is still unclear. I haven't seen the word 'validate' in the Blink loader area. What is (not) validated in this context? cache validation?
133 WebNFC status=experimental	134 WebNFC status=experimental

134 NetworkInformation status=stable	135 NetworkInformation status=stable

135 NetInfoDownlinkMax status=stable	136 NetInfoDownlinkMax status=stable

136 NewMediaPlaybackUi	137 NewMediaPlaybackUi

137 NotificationConstructor status=stable	138 NotificationConstructor status=stable

138 NotificationBadge status=stable	139 NotificationBadge status=stable

139 NotificationImage status=experimental	140 NotificationImage status=experimental

140 NotificationInlineReplies status=experimental	141 NotificationInlineReplies status=experimental

141 Notifications status=stable	142 Notifications status=stable

142 OnDeviceChange status=experimental	143 OnDeviceChange status=experimental

(...skipping 99 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
242 WakeLock status=experimental	243 WakeLock status=experimental

243 WebFontsInterventionV2With2G	244 WebFontsInterventionV2With2G

244 WebFontsInterventionV2WithSlow2G	245 WebFontsInterventionV2WithSlow2G

245 WebFontsInterventionTrigger	246 WebFontsInterventionTrigger

246 WebShare status=experimental	247 WebShare status=experimental

247 Worklet status=experimental	248 Worklet status=experimental

248 WeakMemoryCache	249 WeakMemoryCache

249 DoNotUnlockSharedBuffer	250 DoNotUnlockSharedBuffer

250 ParseHTMLOnMainThread status=test	251 ParseHTMLOnMainThread status=test

251 SendBeaconThrowForBlobWithNonSimpleType status=experimental	252 SendBeaconThrowForBlobWithNonSimpleType status=experimental

OLD	NEW