Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2257713002:
services/ui: GpuService should only be used from a single thread. (Closed)
|
Created:
4 years, 4 months ago by sadrul Modified:
4 years, 4 months ago CC:
chromium-reviews, rjkroege, tfarina, jam, darin-cc_chromium.org, mlamouri+watch-content_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@gpu-service-cleanup Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionservices/ui: GpuService should only be used from a single thread.
Simplify GpuService, and make it usable from only one thread.
BUG=638647
Committed: https://crrev.com/46dc962ad711cfb0f576ff8a210e5bb25730071e
Cr-Commit-Position: refs/heads/master@{#413735}
Patch Set 1 : . #Patch Set 2 : . #Patch Set 3 : . #Patch Set 4 : tot merge #Messages
Total messages: 31 (21 generated)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== services/ui: GpuService should only be used from a single thread. [wip] BUG=638647 ========== to ========== services/ui: GpuService should only be used from a single thread. Simplify GpuService, and make it usable from only one thread. BUG=638647 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sadrul@chromium.org changed reviewers: + fsamuel@chromium.org
Mind taking a first look? Thanks!
Nice! LGTM
Nice! LGTM
sadrul@chromium.org changed reviewers: + piman@chromium.org
+piman@ for review.
lgtm
sadrul@chromium.org changed reviewers: + sky@chromium.org
+sky@ for owner
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by sadrul@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org, piman@chromium.org Link to the patchset: https://codereview.chromium.org/2257713002/#ps80001 (title: "tot merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== services/ui: GpuService should only be used from a single thread. Simplify GpuService, and make it usable from only one thread. BUG=638647 ========== to ========== services/ui: GpuService should only be used from a single thread. Simplify GpuService, and make it usable from only one thread. BUG=638647 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== services/ui: GpuService should only be used from a single thread. Simplify GpuService, and make it usable from only one thread. BUG=638647 ========== to ========== services/ui: GpuService should only be used from a single thread. Simplify GpuService, and make it usable from only one thread. BUG=638647 Committed: https://crrev.com/46dc962ad711cfb0f576ff8a210e5bb25730071e Cr-Commit-Position: refs/heads/master@{#413735} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/46dc962ad711cfb0f576ff8a210e5bb25730071e Cr-Commit-Position: refs/heads/master@{#413735} |
