Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2257703003: Replace LANGUAGE_END with LAST_LANGUAGE_MODE (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
neis, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Replace LANGUAGE_END with LAST_LANGUAGE_MODE BUG= Committed: https://crrev.com/9324efca85710ebb14f21ef8476447e21cbe3f35 Cr-Commit-Position: refs/heads/master@{#38707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/ast/scopes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic-state.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-18 09:32:39 UTC) #2
marja
lgtm
4 years, 4 months ago (2016-08-18 09:36:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257703003/1
4 years, 4 months ago (2016-08-18 09:39:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 10:20:04 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9324efca85710ebb14f21ef8476447e21cbe3f35 Cr-Commit-Position: refs/heads/master@{#38707}
4 years, 4 months ago (2016-08-18 10:20:30 UTC) #8
Michael Hablich
4 years, 4 months ago (2016-08-18 12:04:41 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2259853002/ by hablich@chromium.org.

The reason for reverting is: Needed to land revert
https://codereview.chromium.org/2257133002/.

Powered by Google App Engine
This is Rietveld 408576698