Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22577010: Printing: Add a basic printing mode without print preview and cloud print. (Closed)

Created:
7 years, 4 months ago by Lei Zhang
Modified:
7 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, jam, yoshiki+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, robertshield, ajwong+watch_chromium.org, chromium-apps-reviews_chromium.org, whywhat, miguelg, selim
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Printing: Add a basic printing mode without print preview and cloud print. BUG=147070 TBR=cimamoglu@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217025

Patch Set 1 : #

Total comments: 12

Patch Set 2 : Address comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+564 lines, -1094 lines) Patch
M build/common.gypi View 1 2 3 chunks +9 lines, -2 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/automation/automation_util.cc View 5 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 5 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_posix.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_view_manager.h View 3 chunks +3 lines, -128 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 1 6 chunks +5 lines, -494 lines 0 comments Download
A + chrome/browser/printing/print_view_manager_base.h View 6 chunks +24 lines, -81 lines 0 comments Download
A + chrome/browser/printing/print_view_manager_base.cc View 1 18 chunks +45 lines, -189 lines 0 comments Download
A chrome/browser/printing/print_view_manager_basic.h View 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/printing/print_view_manager_basic.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 4 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 8 chunks +34 lines, -9 lines 0 comments Download
M chrome/browser/task_manager/tab_contents_resource_provider.cc View 5 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/apps/chrome_shell_window_delegate.cc View 3 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 6 chunks +29 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_tab_contents.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.h View 1 2 4 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 12 chunks +36 lines, -23 lines 0 comments Download
M chrome/chrome.gyp View 3 chunks +97 lines, -94 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 chunks +22 lines, -3 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 chunks +15 lines, -5 lines 0 comments Download
M chrome/common/chrome_utility_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/common_message_generator.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_mock_render_thread.h View 4 chunks +6 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_mock_render_thread.cc View 6 chunks +13 lines, -3 lines 0 comments Download
M chrome/renderer/pepper/pepper_pdf_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/ppb_pdf_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/test/base/web_ui_browsertest.cc View 4 chunks +8 lines, -1 line 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_print_settings_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M printing/printing.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
cimamoglu1
Hi Lei, I don't know if you are planning to submit this yourself, but I ...
7 years, 4 months ago (2013-08-11 18:22:50 UTC) #1
cimamoglu1
lgtm
7 years, 4 months ago (2013-08-11 18:23:07 UTC) #2
Lei Zhang
https://codereview.chromium.org/22577010/diff/25001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/22577010/diff/25001/build/common.gypi#newcode2266 build/common.gypi:2266: ['enable_printing==2', { On 2013/08/11 18:22:51, cimamoglu1 wrote: > I ...
7 years, 4 months ago (2013-08-12 06:06:14 UTC) #3
Lei Zhang
TBR for trivial changes: +jln for chrome/common/chrome_utility_messages.h +raymes for contents/
7 years, 4 months ago (2013-08-12 06:07:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/22577010/43001
7 years, 4 months ago (2013-08-12 06:07:44 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=186419
7 years, 4 months ago (2013-08-12 12:40:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/22577010/43001
7 years, 4 months ago (2013-08-12 12:55:17 UTC) #7
Miguel Garcia
On 2013/08/12 12:55:17, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 4 months ago (2013-08-12 16:27:43 UTC) #8
Lei Zhang
On 2013/08/12 16:27:43, Miguel Garcia wrote: > On 2013/08/12 12:55:17, I haz the power (commit-bot) ...
7 years, 4 months ago (2013-08-12 17:02:25 UTC) #9
Lei Zhang
7 years, 4 months ago (2013-08-12 17:16:16 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 manually as r217025 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698