Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: services/shell/public/cpp/service.h

Issue 2257693003: Handle early ServiceRequest errors in shell::ServiceContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/shell/public/cpp/lib/service_context.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/shell/public/cpp/service.h
diff --git a/services/shell/public/cpp/service.h b/services/shell/public/cpp/service.h
index f7f2beeaa87d62d99ee3d5395eb00bacf2375a0f..e84ebd26233b62f7dcfc5813d2bf320fff58e37c 100644
--- a/services/shell/public/cpp/service.h
+++ b/services/shell/public/cpp/service.h
@@ -28,7 +28,7 @@ class Service {
// Called once a bidirectional connection with the Service Manager has been
// established.
// |identity| is the identity of the service instance.
- // Called exactly once before any other method.
+ // Called exactly once before any calls to OnConnect().
virtual void OnStart(const Identity& identity);
// Called when a connection to this service is brokered by the Service
@@ -48,6 +48,9 @@ class Service {
// When used in conjunction with ApplicationRunner, returning true here quits
// the message loop created by ApplicationRunner, which results in the service
// quitting.
+ // No calls to either OnStart() nor OnConnect() may be received after this is
+ // called. It is however possible for this to be called without OnStart() ever
+ // having been called.
virtual bool OnStop();
Connector* connector();
« no previous file with comments | « services/shell/public/cpp/lib/service_context.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698