Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: content/common/mojo/mojo_shell_connection_impl.cc

Issue 2257693003: Handle early ServiceRequest errors in shell::ServiceContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | services/shell/public/cpp/lib/service_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/mojo/mojo_shell_connection_impl.cc
diff --git a/content/common/mojo/mojo_shell_connection_impl.cc b/content/common/mojo/mojo_shell_connection_impl.cc
index e66aef0d1c0111775b07874b01d1287a032c2fc9..0bd2ccad75e167ab5b7a8ef5dd70f6332f5a62d8 100644
--- a/content/common/mojo/mojo_shell_connection_impl.cc
+++ b/content/common/mojo/mojo_shell_connection_impl.cc
@@ -191,6 +191,10 @@ class MojoShellConnectionImpl::IOThreadContext
factory_bindings_.CloseAllBindings();
service_context_.reset();
+ ClearConnectionFiltersOnIOThread();
+ }
+
+ void ClearConnectionFiltersOnIOThread() {
base::AutoLock lock(lock_);
connection_filters_.clear();
}
@@ -252,6 +256,7 @@ class MojoShellConnectionImpl::IOThreadContext
}
bool OnStop() override {
+ ClearConnectionFiltersOnIOThread();
callback_task_runner_->PostTask(FROM_HERE, stop_callback_);
return true;
}
« no previous file with comments | « no previous file | services/shell/public/cpp/lib/service_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698