Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2257643002: Milo-Swarmbucket: Add indication for incomplete logs (Closed)

Created:
4 years, 4 months ago by Ryan Tseng
Modified:
4 years, 3 months ago
Reviewers:
estaab, hinoka
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo-Swarmbucket: Add indication for incomplete logs BUG=625307 Committed: https://github.com/luci/luci-go/commit/766fd9dec55d1c9cc47d14c0bc242db45f7d25be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M milo/appengine/frontend/expectations/buildbot-swarming.TestableLog-Basic_log.html View 1 chunk +1 line, -0 lines 0 comments Download
M milo/appengine/frontend/templates/buildbot/pages/log.html View 1 chunk +3 lines, -0 lines 0 comments Download
M milo/appengine/swarming/buildLog.go View 5 chunks +10 lines, -7 lines 0 comments Download
M milo/appengine/swarming/html.go View 1 chunk +3 lines, -2 lines 0 comments Download
M milo/appengine/swarming/html_data.go View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Ryan Tseng
ptal, small change.
4 years, 3 months ago (2016-08-23 18:14:22 UTC) #6
estaab
lgtm
4 years, 3 months ago (2016-08-24 16:44:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257643002/1
4 years, 3 months ago (2016-08-26 21:38:37 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 21:48:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/766fd9dec55d1c9cc47d14c0bc242db45f7d25be

Powered by Google App Engine
This is Rietveld 408576698