Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2257613002: ImageCapture: add sequence<Point2D> pointsOfInterest and wire for Android (Closed)

Created:
4 years, 4 months ago by mcasas
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, ben+mojo_chromium.org, blink-reviews, chromium-reviews, darin (slow to review), feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ImageCapture: add sequence<Point2D> pointsOfInterest and wire for Android This CL: - adds a Point2D.idl to describe a coordinate [1] and - adds a sequence<Point2D> to describe a series of points of interest [2] - adds the correspondents to image_capture.mojom (note that I'd rather reuse gfx::mojom::PointF but a WebKit presumit prevents me from doing it). - extends the Java_VideoCapture_setPhotoOptions to accept the said list of points of interest - implements the points of interest for (Auto)Focus, limitation: only one such is actually used (enforced by assert). [1] https://w3c.github.io/mediacapture-image/#Point2D [2] https://w3c.github.io/mediacapture-image/#dom-photosettings-pointsofinterest BUG=343894, 518807 Committed: https://crrev.com/0e630cf2c14d1e0c815c95a8710e4d6eb5e09736 Cr-Commit-Position: refs/heads/master@{#413675}

Patch Set 1 : #

Total comments: 7

Patch Set 2 : qinmin@s comments: camelcase variable naming #

Patch Set 3 : haraken@ side comments #

Messages

Total messages: 27 (14 generated)
mcasas
reillyg@ PTAL qinmin@ PTAL at java parts tsepez@: media/mojo/interfaces/image_capture.mojom
4 years, 4 months ago (2016-08-22 18:15:55 UTC) #9
Tom Sepez
On 2016/08/22 18:15:55, mcasas wrote: > reillyg@ PTAL > > qinmin@ PTAL at java parts ...
4 years, 4 months ago (2016-08-22 19:53:01 UTC) #10
Reilly Grant (use Gerrit)
lgtm
4 years, 4 months ago (2016-08-22 20:57:47 UTC) #11
mcasas
haraken@ could you offer some advice: - why can't we use gfx::mojom::PointF from WebKit and/or ...
4 years, 4 months ago (2016-08-22 23:46:09 UTC) #13
qinmin
https://codereview.chromium.org/2257613002/diff/100001/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java (right): https://codereview.chromium.org/2257613002/diff/100001/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java#newcode400 media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:400: final int center_x = Math.round(pointsOfInterest2D[0] * 2000) - 1000; ...
4 years, 4 months ago (2016-08-23 00:02:08 UTC) #14
qinmin
On 2016/08/23 00:02:08, qinmin wrote: > https://codereview.chromium.org/2257613002/diff/100001/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java > File > media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java > (right): > > ...
4 years, 4 months ago (2016-08-23 00:02:27 UTC) #15
haraken
On 2016/08/22 23:46:09, mcasas wrote: > haraken@ could you offer some advice: > - why ...
4 years, 4 months ago (2016-08-23 00:18:49 UTC) #17
mcasas
On 2016/08/23 00:18:49, haraken wrote: > On 2016/08/22 23:46:09, mcasas wrote: > > haraken@ could ...
4 years, 4 months ago (2016-08-23 00:44:44 UTC) #18
mcasas
https://codereview.chromium.org/2257613002/diff/100001/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java (right): https://codereview.chromium.org/2257613002/diff/100001/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java#newcode400 media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:400: final int center_x = Math.round(pointsOfInterest2D[0] * 2000) - 1000; ...
4 years, 4 months ago (2016-08-23 00:45:46 UTC) #19
haraken
LGTM on my side. On 2016/08/23 00:44:44, mcasas wrote: > On 2016/08/23 00:18:49, haraken wrote: ...
4 years, 4 months ago (2016-08-23 02:13:43 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257613002/140001
4 years, 4 months ago (2016-08-23 02:18:05 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:140001)
4 years, 4 months ago (2016-08-23 05:57:10 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 05:58:54 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0e630cf2c14d1e0c815c95a8710e4d6eb5e09736
Cr-Commit-Position: refs/heads/master@{#413675}

Powered by Google App Engine
This is Rietveld 408576698