Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2257563002: Move summary inspection code out of pkg/analyzer/lib. (Closed)

Created:
4 years, 4 months ago by Paul Berry
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move summary inspection code out of pkg/analyzer/lib. It depends on mirrors, which aren't supported by Flutter. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e31e7757d5b356b5661fd3a2423f571c5b3dbfb2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -442 lines) Patch
D pkg/analyzer/lib/src/summary/inspect.dart View 1 chunk +0 lines, -441 lines 0 comments Download
M pkg/analyzer/tool/summary/inspect.dart View 2 chunks +435 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 4 months ago (2016-08-17 18:33:54 UTC) #2
scheglov
LGTM
4 years, 4 months ago (2016-08-17 18:34:41 UTC) #3
Paul Berry
4 years, 4 months ago (2016-08-17 19:15:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e31e7757d5b356b5661fd3a2423f571c5b3dbfb2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698