Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2257553002: Fix OSX 10.12 compilation errors in chrome/browser/ui. (Closed)

Created:
4 years, 4 months ago by pwnall
Modified:
4 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix OSX 10.12 compilation errors in chrome/browser/ui. BUG= Committed: https://crrev.com/b7413b8f60c48c11d36bc15023bc2c9d08c15406 Cr-Commit-Position: refs/heads/master@{#413371}

Patch Set 1 #

Patch Set 2 : Conditional compilation for older OSX SDKs #

Patch Set 3 : Moved 10.12 SDK defines to one header. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -11 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 2 2 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/animatable_image.mm View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm View 2 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_quit_panel_controller.mm View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_window.mm View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/spinner_view.mm View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/sprite_view.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/status_bubble_mac.mm View 2 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 2 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
pwnall
The OSX 10.12 SDK added CAAnimationDelegate and CALayerDelegate protocols and used them to strongly type ...
4 years, 4 months ago (2016-08-17 22:46:03 UTC) #3
pwnall
Forgot to fill in the reviewer field :'(
4 years, 4 months ago (2016-08-17 22:47:08 UTC) #5
pwnall
Can you please take a look at this CL? I previously assigned this to nektarios ...
4 years, 4 months ago (2016-08-19 01:35:06 UTC) #12
Avi (use Gerrit)
lgtm
4 years, 4 months ago (2016-08-21 04:39:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257553002/40001
4 years, 4 months ago (2016-08-21 05:47:28 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-21 06:56:54 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-21 06:58:13 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b7413b8f60c48c11d36bc15023bc2c9d08c15406
Cr-Commit-Position: refs/heads/master@{#413371}

Powered by Google App Engine
This is Rietveld 408576698