Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7077)

Unified Diff: chrome/browser/about_flags.h

Issue 2257533005: Change logging of about:flags from actions to a histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.h
diff --git a/chrome/browser/about_flags.h b/chrome/browser/about_flags.h
index 25155247a794464fb22bccf0c697b75260f0f146..2ca0e2767f9031a31091ab18803a011c2886fbe3 100644
--- a/chrome/browser/about_flags.h
+++ b/chrome/browser/about_flags.h
@@ -87,12 +87,11 @@ void RecordUMAStatistics(flags_ui::FlagsStorage* flags_storage);
// Returns the UMA id for the specified switch name.
base::HistogramBase::Sample GetSwitchUMAId(const std::string& switch_name);
-// Sends stats (as UMA histogram) about command_line_difference.
-// This is used on ChromeOS to report flags that lead to browser restart.
-// |command_line_difference| is the result of
-// AreSwitchesIdenticalToCurrentCommandLine().
-void ReportCustomFlags(const std::string& uma_histogram_hame,
- const std::set<std::string>& command_line_difference);
+// Sends stats (as UMA histogram) about a set of command line |flags| in
+// a histogram, with an enum value for each flag in |flags|, based on the
+// hash of the flag name.
+void ReportAboutFlagsHistogram(const std::string& uma_histogram_hame,
Ilya Sherman 2016/08/29 22:31:29 nit: s/hame/name here too :)
Alexei Svitkine (slow) 2016/08/30 15:04:22 Done.
+ const std::set<std::string>& flags);
namespace testing {
« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698