Change logging of about:flags from actions to a histogram.

tools/metrics/actions/extract_actions.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Extract UserMetrics "actions" strings from the Chrome source.
 
 This program generates the list of known actions we expect to see in the
 user behavior logs.  It walks the Chrome source, looking for calls to
@@ skipping 73 matching lines @@
 # generate the known actions to AddComputedActions() below.
 KNOWN_COMPUTED_USERS = (
   'back_forward_menu_model.cc',
   'options_page_view.cc',
   'render_view_host.cc',  # called using webkit identifiers
   'user_metrics.cc',  # method definition
   'new_tab_ui.cc',  # most visited clicks 1-9
   'extension_metrics_module.cc', # extensions hook for user metrics
   'language_options_handler_common.cc', # languages and input methods in CrOS
   'cros_language_options_handler.cc', # languages and input methods in CrOS
-  'about_flags.cc', # do not generate a warning; see AddAboutFlagsActions()
   'external_metrics.cc',  # see AddChromeOSActions()
   'core_options_handler.cc',  # see AddWebUIActions()
   'browser_render_process_host.cc',  # see AddRendererActions()
   'render_thread_impl.cc',  # impl of RenderThread::RecordComputedAction()
   'render_process_host_impl.cc',  # browser side impl for
                                   # RenderThread::RecordComputedAction()
   'mock_render_thread.cc',  # mock of RenderThread::RecordComputedAction()
   'ppb_pdf_impl.cc',  # see AddClosedSourceActions()
   'pepper_pdf_host.cc',  # see AddClosedSourceActions()
   'record_user_action.cc', # see RecordUserAction.java
@@ skipping 84 matching lines @@
     actions.add('MostVisited%d' % i)
 
   # Actions for language_options_handler.cc (Chrome OS specific).
   for input_method_id in INPUT_METHOD_IDS:
     actions.add('LanguageOptions_DisableInputMethod_%s' % input_method_id)
     actions.add('LanguageOptions_EnableInputMethod_%s' % input_method_id)
   for language_code in LANGUAGE_CODES:
     actions.add('LanguageOptions_UiLanguageChange_%s' % language_code)
     actions.add('LanguageOptions_SpellCheckLanguageChange_%s' % language_code)
 
-def AddWebKitEditorActions(actions):
-  """Add editor actions from editor_client_impl.cc.
-
-  Arguments:
-    actions: set of actions to add to.
-  """
-  action_re = re.compile(r'''\{ [\w']+, +\w+, +"(.*)" +\},''')
-
-  editor_file = os.path.join(REPOSITORY_ROOT, 'webkit', 'api', 'src',
-                             'EditorClientImpl.cc')
-  for line in open(editor_file):
-    match = action_re.search(line)
-    if match:  # Plain call to RecordAction
-      actions.add(match.group(1))
 
 def AddPDFPluginActions(actions):
   """Add actions that are sent by the PDF plugin.
 
   Arguments
     actions: set of actions to add to.
   """
   actions.add('PDF.LoadFailure')
   actions.add('PDF.LoadSuccess')
   actions.add('PDF.PreviewDocumentLoadFailure')
   actions.add('PDF.PrintPage')
   actions.add('PDF.ZoomFromBrowser')
   actions.add('PDF_Unsupported_3D')
   actions.add('PDF_Unsupported_Attachment')
   actions.add('PDF_Unsupported_Bookmarks')
   actions.add('PDF_Unsupported_Digital_Signature')
   actions.add('PDF_Unsupported_Movie')
   actions.add('PDF_Unsupported_Portfolios_Packages')
   actions.add('PDF_Unsupported_Rights_Management')
   actions.add('PDF_Unsupported_Screen')
   actions.add('PDF_Unsupported_Shared_Form')
   actions.add('PDF_Unsupported_Shared_Review')
   actions.add('PDF_Unsupported_Sound')
   actions.add('PDF_Unsupported_XFA')
 
-def AddAboutFlagsActions(actions):
-  """This parses the experimental feature flags for UMA actions.
-
-  Arguments:
-    actions: set of actions to add to.
-  """
-  about_flags = os.path.join(REPOSITORY_ROOT, 'chrome', 'browser',
-                             'about_flags.cc')
-  flag_name_re = re.compile(r'\s*"([0-9a-zA-Z\-_]+)",\s*// FLAGS:RECORD_UMA')
-  for line in open(about_flags):
-    match = flag_name_re.search(line)
-    if match:
-      actions.add("AboutFlags_" + match.group(1))
-    # If the line contains the marker but was not matched by the regex, put up
-    # an error if the line is not a comment.
-    elif 'FLAGS:RECORD_UMA' in line and line[0:2] != '//':
-      print >>sys.stderr, 'WARNING: This line is marked for recording ' + \
-          'about:flags metrics, but is not in the proper format:\n' + line
-
 def AddBookmarkManagerActions(actions):
   """Add actions that are used by BookmarkManager.
 
   Arguments
     actions: set of actions to add to.
   """
   actions.add('BookmarkManager_Command_AddPage')
   actions.add('BookmarkManager_Command_Copy')
   actions.add('BookmarkManager_Command_Cut')
   actions.add('BookmarkManager_Command_Delete')
@@ skipping 480 matching lines @@
     actions_element.appendChild(
         _CreateActionTag(doc, action, actions_dict.get(action, None)))
 
   return print_style.GetPrintStyle().PrettyPrintNode(doc)
 
 
 def UpdateXml(original_xml):
   actions, actions_dict, comment_nodes = ParseActionFile(original_xml)
 
   AddComputedActions(actions)
-  # TODO(fmantek): bring back webkit editor actions.
-  # AddWebKitEditorActions(actions)
-  AddAboutFlagsActions(actions)
   AddWebUIActions(actions)
 
   AddLiteralActions(actions)
 
   # print "Scanned {0} number of files".format(number_of_files_total)
   # print "Found {0} entries".format(len(actions))
 
   AddAutomaticResetBannerActions(actions)
   AddBookmarkManagerActions(actions)
   AddChromeOSActions(actions)
   AddExtensionActions(actions)
   AddHistoryPageActions(actions)
   AddPDFPluginActions(actions)
 
   return PrettyPrint(actions, actions_dict, comment_nodes)
 
 
 def main(argv):
   presubmit_util.DoPresubmitMain(argv, 'actions.xml', 'actions.old.xml',
                                  'extract_actions.py', UpdateXml)
 
 if '__main__' == __name__:
   sys.exit(main(sys.argv))