tools/metrics/histograms/histograms.xml - Issue 2257533005: Change logging of about:flags from actions to a histogram.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2257533005: Change logging of about:flags from actions to a histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index aca0658928cccb66e0936859f248eb27d7c10426..ecffef05d5ae1d8421ff953870ca4f926160db61 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -72,6 +72,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

+<histogram name="AboutFlags.Seen" enum="LoginCustomFlags">

Ilya Sherman 2016/08/29 21:19:59 nit: WDYT of "FlagsAtStartup" rather than "Seen"?

Ilya Sherman 2016/08/29 21:19:59 It looks like you're adding a new top-level catego

Alexei Svitkine (slow) 2016/08/29 21:50:58 Good idea - renamed to Launch.FlagsAtStartup. I p

+ <owner>asvitkine@chromium.org</owner>

+ <summary>

+ Logs which Chrome flags from about:flags were active on start up.

+ </summary>

+</histogram>

<owner>dmazzoni@chromium.org</owner>

<owner>kenjibaheux@google.com</owner>

« chrome/browser/about_flags.cc ('K') | « tools/metrics/actions/extract_actions.py ('k') | no next file » | no next file with comments »