components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc - Issue 2257533003: Adding a previews object, PreviewsDataSavings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

Issue 2257533003: Adding a previews object, PreviewsDataSavings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bengr comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc ('k') | components/data_reduction_proxy/core/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

index c9d36f3f5153a87be14418014dd8cbac7d9ac92d..cfc8569be6b263242f11d1723a2d2a55fef865d4 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

@@ -57,31 +57,31 @@ class DataReductionProxySettingsTest

settings_->InitPrefMembers();

}

};

TEST_F(DataReductionProxySettingsTest, TestIsProxyEnabledOrManaged) {

InitPrefMembers();

// The proxy is disabled initially.

test_context_->config()->SetStateForTest(false, true);

EXPECT_FALSE(settings_->IsDataReductionProxyEnabled());

- EXPECT_FALSE(settings_->IsDataSaverEnabled());

+ EXPECT_FALSE(settings_->UpdateDataSavings(std::string(), 0, 0));

EXPECT_FALSE(settings_->IsDataReductionProxyManaged());

CheckOnPrefChange(true, true, false);

EXPECT_TRUE(settings_->IsDataReductionProxyEnabled());

- EXPECT_TRUE(settings_->IsDataSaverEnabled());

+ EXPECT_TRUE(settings_->UpdateDataSavings(std::string(), 0, 0));

EXPECT_FALSE(settings_->IsDataReductionProxyManaged());

CheckOnPrefChange(true, true, true);

EXPECT_TRUE(settings_->IsDataReductionProxyEnabled());

- EXPECT_TRUE(settings_->IsDataSaverEnabled());

+ EXPECT_TRUE(settings_->UpdateDataSavings(std::string(), 0, 0));

EXPECT_TRUE(settings_->IsDataReductionProxyManaged());

test_context_->RunUntilIdle();

}

TEST_F(DataReductionProxySettingsTest, TestCanUseDataReductionProxy) {

InitPrefMembers();

// The proxy is disabled initially.

test_context_->config()->SetStateForTest(false, true);