Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: components/data_reduction_proxy/core/common/data_savings_recorder.h

Issue 2257533003: Adding a previews object, PreviewsDataSavings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and design change. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/common/data_savings_recorder.h
diff --git a/components/data_reduction_proxy/core/common/data_savings_recorder.h b/components/data_reduction_proxy/core/common/data_savings_recorder.h
index 461f4173a98214c438e0c3aaa60e913a014eb7ee..bf724dc2c4c3975bef8aa8f446724920f9487476 100644
--- a/components/data_reduction_proxy/core/common/data_savings_recorder.h
+++ b/components/data_reduction_proxy/core/common/data_savings_recorder.h
@@ -15,15 +15,18 @@ namespace data_reduction_proxy {
// the original size of the data, and the request type.
class DataSavingsRecorder {
public:
// Records detailed data usage. Assumes |data_used| is recorded already by
// previous handling of URLRequests. Also records daily data savings
// statistics to prefs and reports data savings UMA. |data_used| and
// |original_size| are measured in bytes.
virtual void UpdateDataSavings(const std::string& data_usage_host,
bengr 2016/08/31 22:02:25 Should this only be called if ShouldRecordDataSavi
RyanSturm 2016/09/02 01:17:51 I'm combining the methods to return a bool and do
int64_t data_used,
int64_t original_size) = 0;
+
+ // Whether data savings should be recorded.
bengr 2016/08/31 22:02:26 Make this a complete sentence: Returns true if dat
RyanSturm 2016/09/02 01:17:51 Done.
+ virtual bool ShouldRecordDataSavings() const = 0;
};
} // namespace data_reduction_proxy
#endif // COMPONENTS_DATA_REDUCTION_PROXY_CORE_COMMON_DATA_SAVINGS_RECORDER_H_

Powered by Google App Engine
This is Rietveld 408576698