[Sync] Move StartAssociation from NonUIDataTypeController to SharedChangeProcessor.

[Sync] Move StartAssociation from NonUIDataTypeController to SharedChangeProcessor.

This CL copies a utility function, BindToTaskRunner, from //chromecast/base.
I discussed adding it to //base with danakj@ but apparently it has been
rejected before.

BUG=638771
Committed: https://crrev.com/510f3e9bff01537bca7799b3e9cc2142d64f7376
Cr-Commit-Position: refs/heads/master@{#413175}

[maxbogue, 2016-08-17 23:07:24]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 23:08:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 23:57:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 23:57:41]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-08-18 00:03:04]

maxbogue@chromium.org changed reviewers:
+ pavely@chromium.org

[maxbogue, 2016-08-18 00:03:04]

Pavel, PTAL!

[maxbogue, 2016-08-18 00:29:42]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 00:30:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-08-18 00:36:58]

Description was changed from

==========
[Sync] Move StartAssociation from NonUIDataTypeController to
SharedChangeProcessor.

BUG=638771
==========

to

==========
[Sync] Move StartAssociation from NonUIDataTypeController to
SharedChangeProcessor.

This CL copies a utility function, BindToTaskRunner, from //chromecast/base.
I discussed adding it to //base with danakj@ but apparently it has been
rejected before.

BUG=638771
==========

[commit-bot: I haz the power, 2016-08-18 00:55:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 00:55:37]

Dry run: Exceeded global retry quota

[maxbogue, 2016-08-18 17:04:18]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 17:04:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 18:10:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 18:10:03]

Dry run: This issue passed the CQ dry run.

[pavely, 2016-08-18 18:10:06]

https://codereview.chromium.org/2257523003/diff/40001/components/sync/driver/...
File components/sync/driver/non_ui_data_type_controller.cc (right):

https://codereview.chromium.org/2257523003/diff/40001/components/sync/driver/...
components/sync/driver/non_ui_data_type_controller.cc:186: local_service_ =
local_service;
Previously local_service_ was assigned on model thread immediately after it is
retrieved from SyncClient. With this change local_service_ is only assigned when
StartDone callback is called on UI thread.
Is it possible that NonUIDataTypeController::StopLocalServiceAsync is called
during association? In this case by the time call reaches
NonUIDataTypeController::StopLocalService on model thread local_service_ would
still be not set and therefore SyncableService::StopSyncing will not be called.

[maxbogue, 2016-08-18 22:00:22]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 22:01:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-08-18 22:19:29]

https://codereview.chromium.org/2257523003/diff/40001/components/sync/driver/...
File components/sync/driver/non_ui_data_type_controller.cc (right):

https://codereview.chromium.org/2257523003/diff/40001/components/sync/driver/...
components/sync/driver/non_ui_data_type_controller.cc:186: local_service_ =
local_service;
On 2016/08/18 18:10:06, pavely wrote:
> Previously local_service_ was assigned on model thread immediately after it is
> retrieved from SyncClient. With this change local_service_ is only assigned
when
> StartDone callback is called on UI thread.
> Is it possible that NonUIDataTypeController::StopLocalServiceAsync is called
> during association? In this case by the time call reaches
> NonUIDataTypeController::StopLocalService on model thread local_service_ would
> still be not set and therefore SyncableService::StopSyncing will not be
called.

I think it is possible, so I have moved the local_service_ pointer inside the
SharedChangeProcessor. PTAL at the most recent patch set!

[commit-bot: I haz the power, 2016-08-18 23:12:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 23:12:09]

Dry run: This issue passed the CQ dry run.

[pavely, 2016-08-19 17:04:29]

lgtm

[maxbogue, 2016-08-19 17:13:01]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-08-19 17:13:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 17:18:14]

Description was changed from

==========
[Sync] Move StartAssociation from NonUIDataTypeController to
SharedChangeProcessor.

This CL copies a utility function, BindToTaskRunner, from //chromecast/base.
I discussed adding it to //base with danakj@ but apparently it has been
rejected before.

BUG=638771
==========

to

==========
[Sync] Move StartAssociation from NonUIDataTypeController to
SharedChangeProcessor.

This CL copies a utility function, BindToTaskRunner, from //chromecast/base.
I discussed adding it to //base with danakj@ but apparently it has been
rejected before.

BUG=638771
==========

[commit-bot: I haz the power, 2016-08-19 17:18:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-19 17:23:53]

Description was changed from

==========
[Sync] Move StartAssociation from NonUIDataTypeController to
SharedChangeProcessor.

This CL copies a utility function, BindToTaskRunner, from //chromecast/base.
I discussed adding it to //base with danakj@ but apparently it has been
rejected before.

BUG=638771
==========

to

==========
[Sync] Move StartAssociation from NonUIDataTypeController to
SharedChangeProcessor.

This CL copies a utility function, BindToTaskRunner, from //chromecast/base.
I discussed adding it to //base with danakj@ but apparently it has been
rejected before.

BUG=638771

Committed: https://crrev.com/510f3e9bff01537bca7799b3e9cc2142d64f7376
Cr-Commit-Position: refs/heads/master@{#413175}
==========

[commit-bot: I haz the power, 2016-08-19 17:23:54]

Patchset 4 (id:??) landed as
https://crrev.com/510f3e9bff01537bca7799b3e9cc2142d64f7376
Cr-Commit-Position: refs/heads/master@{#413175}