Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2257523002: prerender_test_server.py: bind to loopback interface (Closed)

Created:
4 years, 4 months ago by pasko
Modified:
4 years, 4 months ago
Reviewers:
droger
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

prerender_test_server.py: bind to loopback interface This prevents exposing the server outside of the local machine (given a sane firewall). BUG=none Committed: https://crrev.com/01556e05987daa05cbd456d410d972fe3def505a Cr-Commit-Position: refs/heads/master@{#412596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/prerender/tools/prerender_test_server/prerender_test_server.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pasko
4 years, 4 months ago (2016-08-17 16:57:13 UTC) #3
droger
lgtm
4 years, 4 months ago (2016-08-17 17:11:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257523002/1
4 years, 4 months ago (2016-08-17 17:24:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 18:41:06 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 18:47:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01556e05987daa05cbd456d410d972fe3def505a
Cr-Commit-Position: refs/heads/master@{#412596}

Powered by Google App Engine
This is Rietveld 408576698