third_party/WebKit/Source/platform/graphics/BitmapImage.cpp - Issue 2257513002: Refactor ImageDecoder factories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/BitmapImage.cpp

Issue 2257513002: Refactor ImageDecoder factories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/BitmapImage.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp b/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp

index 6bd22c923ea3ab9b77ed1e4398427c6af54cfd5c..4e0d82778559c193233e4903edf3607760c1ce31 100644

--- a/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp

+++ b/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp

@@ -198,9 +198,9 @@ Image::SizeAvailability BitmapImage::setData(PassRefPtr<SharedBuffer> data, bool

if (!length)

return SizeAvailable;

- // If ImageSource::setData() returns Invalid, we know that this is a decode error.

+ // If ImageSource::setData() fails, we know that this is a decode error.

// Report size available so that it gets registered as such in ImageResource.

- if (m_source.setData(*data, allDataReceived) == ImageDecoder::SniffResult::Invalid)

+ if (!m_source.setData(data, allDataReceived))

return SizeAvailable;

return dataChanged(allDataReceived);