Refactor ImageDecoder factories

third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

Index: third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp
diff --git a/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp b/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp
index 530aee3d338b7529ad0aed1f37fa86912648c35f..6d168ad1edd6a516fcf0159b3874b8a58029f838 100644
--- a/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp
+++ b/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp
@@ -90,9 +90,9 @@ void NotificationImageLoader::didFinishLoading(unsigned long resourceIdentifier,
         DEFINE_THREAD_SAFE_STATIC_LOCAL(CustomCountHistogram, fileSizeHistogram, new CustomCountHistogram("Notifications.Icon.FileSize", 1, 10000000 /* ~10mb max */, 50 /* buckets */));
         fileSizeHistogram.count(m_data->size());
 
-        std::unique_ptr<ImageDecoder> decoder = ImageDecoder::create(ImageDecoder::determineImageType(*m_data.get()), ImageDecoder::AlphaPremultiplied, ImageDecoder::GammaAndColorProfileApplied);
+        std::unique_ptr<ImageDecoder> decoder = ImageDecoder::create(m_data, true /* allDataReceived */,

[Peter Kasting, 2016/08/19 23:04:58]

Nit: I'd just omit the comment

[f(malita), 2016/08/22 01:51:15]

Done.

[Peter Beverloo, 2016/08/23 13:06:20]

Heh, I was about to comment with the opposite based on the latest PS— the
meaning of "true" is not clear when reading of this code, which is why,
historically, Blink preferred enumerations over booleans.

I don't feel super strongly, but do feel it's clearer with the comment.

+            ImageDecoder::AlphaPremultiplied, ImageDecoder::GammaAndColorProfileApplied);
         if (decoder) {
-            decoder->setData(m_data.get(), true /* allDataReceived */);
             // The |ImageFrame*| is owned by the decoder.
             ImageFrame* imageFrame = decoder->frameBufferAtIndex(0);
             if (imageFrame) {