Improve some debug tools for mus.

Improve some debug tools in mus.

1. Add WindowId::ToString() for ease of logging/printf.
2. Add ServerWindow::GetDebugWindowInfo() that contains the debug info
   for the current server window that is printed as part of
   GetDebugWindowHierarchy().
3. Make the debug functions on ServerWindow and WindowManagerState also
   be defined if DCHECK_ALWAYS_ON is defined.
4. Fix debug accelerator to print ServerWindow hierarchy. All event
   flags were being checked before so having something like num lock on
   would prevent the accelerator from being triggered.

BUG=none

Committed: https://crrev.com/a55c360299fc155757eab2c6c9df8a8a2312da14
Cr-Commit-Position: refs/heads/master@{#412620}

[kylechar, 2016-08-17 16:15:33]

Description was changed from

==========
Improve some debug tools for mash.

A few small changes:
1. Add WindowId::ToString() for ease of logging/printf.
2. Add ServerWindow::GetDebugWindowInfo() that contains the debug info
   for the current server window that is printed as part of
   GetDebugWindowHierarchy().
3. Make the debug functions on ServerWindow and WindowManagerState also
   be defined if DCHECK_ALWAYS_ON is defined.
4. Fix debug accelerator to print ServerWindow hierarchy. All event
   flags were being checked before so having something like num lock on
   would prevent the accelerator from being triggered.

BUG=none
==========

to

==========
Improve some debug tools for mash.

1. Add WindowId::ToString() for ease of logging/printf.
2. Add ServerWindow::GetDebugWindowInfo() that contains the debug info
   for the current server window that is printed as part of
   GetDebugWindowHierarchy().
3. Make the debug functions on ServerWindow and WindowManagerState also
   be defined if DCHECK_ALWAYS_ON is defined.
4. Fix debug accelerator to print ServerWindow hierarchy. All event
   flags were being checked before so having something like num lock on
   would prevent the accelerator from being triggered.

BUG=none
==========

[kylechar, 2016-08-17 16:15:53]

Description was changed from

==========
Improve some debug tools for mash.

1. Add WindowId::ToString() for ease of logging/printf.
2. Add ServerWindow::GetDebugWindowInfo() that contains the debug info
   for the current server window that is printed as part of
   GetDebugWindowHierarchy().
3. Make the debug functions on ServerWindow and WindowManagerState also
   be defined if DCHECK_ALWAYS_ON is defined.
4. Fix debug accelerator to print ServerWindow hierarchy. All event
   flags were being checked before so having something like num lock on
   would prevent the accelerator from being triggered.

BUG=none
==========

to

==========
Improve some debug tools in mus.

1. Add WindowId::ToString() for ease of logging/printf.
2. Add ServerWindow::GetDebugWindowInfo() that contains the debug info
   for the current server window that is printed as part of
   GetDebugWindowHierarchy().
3. Make the debug functions on ServerWindow and WindowManagerState also
   be defined if DCHECK_ALWAYS_ON is defined.
4. Fix debug accelerator to print ServerWindow hierarchy. All event
   flags were being checked before so having something like num lock on
   would prevent the accelerator from being triggered.

BUG=none
==========

[kylechar, 2016-08-17 16:16:13]

Description was changed from

==========
Improve some debug tools in mus.

1. Add WindowId::ToString() for ease of logging/printf.
2. Add ServerWindow::GetDebugWindowInfo() that contains the debug info
   for the current server window that is printed as part of
   GetDebugWindowHierarchy().
3. Make the debug functions on ServerWindow and WindowManagerState also
   be defined if DCHECK_ALWAYS_ON is defined.
4. Fix debug accelerator to print ServerWindow hierarchy. All event
   flags were being checked before so having something like num lock on
   would prevent the accelerator from being triggered.

BUG=none
==========

to

==========
Improve some debug tools in mus.

1. Add WindowId::ToString() for ease of logging/printf.
2. Add ServerWindow::GetDebugWindowInfo() that contains the debug info
   for the current server window that is printed as part of
   GetDebugWindowHierarchy().
3. Make the debug functions on ServerWindow and WindowManagerState also
   be defined if DCHECK_ALWAYS_ON is defined.
4. Fix debug accelerator to print ServerWindow hierarchy. All event
   flags were being checked before so having something like num lock on
   would prevent the accelerator from being triggered.

BUG=none
==========

[kylechar, 2016-08-17 16:21:16]

kylechar@chromium.org changed reviewers:
+ msw@chromium.org, sky@chromium.org

[sky, 2016-08-17 19:01:06]

LGTM

https://codereview.chromium.org/2257503002/diff/20001/services/ui/ws/server_w...
File services/ui/ws/server_window.cc (right):

https://codereview.chromium.org/2257503002/diff/20001/services/ui/ws/server_w...
services/ui/ws/server_window.cc:394: "id=%u:%u visible=%s bounds=%d,%d %dx%d
%s", id_.client_id, id_.window_id,
id_.ToString() ?

https://codereview.chromium.org/2257503002/diff/20001/services/ui/ws/window_m...
File services/ui/ws/window_manager_state.h (right):

https://codereview.chromium.org/2257503002/diff/20001/services/ui/ws/window_m...
services/ui/ws/window_manager_state.h:101: bool Matches(const ui::KeyEvent&
event) const;
Functions before members.

[kylechar, 2016-08-17 19:10:12]

Thanks!

https://codereview.chromium.org/2257503002/diff/20001/services/ui/ws/server_w...
File services/ui/ws/server_window.cc (right):

https://codereview.chromium.org/2257503002/diff/20001/services/ui/ws/server_w...
services/ui/ws/server_window.cc:394: "id=%u:%u visible=%s bounds=%d,%d %dx%d
%s", id_.client_id, id_.window_id,
On 2016/08/17 19:01:05, sky wrote:
> id_.ToString() ?

Done.

https://codereview.chromium.org/2257503002/diff/20001/services/ui/ws/window_m...
File services/ui/ws/window_manager_state.h (right):

https://codereview.chromium.org/2257503002/diff/20001/services/ui/ws/window_m...
services/ui/ws/window_manager_state.h:101: bool Matches(const ui::KeyEvent&
event) const;
On 2016/08/17 19:01:05, sky wrote:
> Functions before members.

Done.

[kylechar, 2016-08-17 19:10:46]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-08-17 19:10:46]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2257503002/#ps40001
(title: "Fixes.")

[commit-bot: I haz the power, 2016-08-17 19:11:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 20:03:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 20:03:43]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-08-17 20:10:04]

Description was changed from

==========
Improve some debug tools in mus.

1. Add WindowId::ToString() for ease of logging/printf.
2. Add ServerWindow::GetDebugWindowInfo() that contains the debug info
   for the current server window that is printed as part of
   GetDebugWindowHierarchy().
3. Make the debug functions on ServerWindow and WindowManagerState also
   be defined if DCHECK_ALWAYS_ON is defined.
4. Fix debug accelerator to print ServerWindow hierarchy. All event
   flags were being checked before so having something like num lock on
   would prevent the accelerator from being triggered.

BUG=none
==========

to

==========
Improve some debug tools in mus.

1. Add WindowId::ToString() for ease of logging/printf.
2. Add ServerWindow::GetDebugWindowInfo() that contains the debug info
   for the current server window that is printed as part of
   GetDebugWindowHierarchy().
3. Make the debug functions on ServerWindow and WindowManagerState also
   be defined if DCHECK_ALWAYS_ON is defined.
4. Fix debug accelerator to print ServerWindow hierarchy. All event
   flags were being checked before so having something like num lock on
   would prevent the accelerator from being triggered.

BUG=none

Committed: https://crrev.com/a55c360299fc155757eab2c6c9df8a8a2312da14
Cr-Commit-Position: refs/heads/master@{#412620}
==========

[commit-bot: I haz the power, 2016-08-17 20:10:05]

Patchset 3 (id:??) landed as
https://crrev.com/a55c360299fc155757eab2c6c9df8a8a2312da14
Cr-Commit-Position: refs/heads/master@{#412620}