Add "AutofillScanCardholderName" feature.

Add "AutofillScanCardholderName" feature.

Add a feature named "AutofillScanCardholderName", which is disabled by
default.

BUG=637896
Committed: https://crrev.com/9f59eaa1f8d3822d765edbb8d8d982f34a1e7026
Cr-Commit-Position: refs/heads/master@{#413588}

[please use gerrit instead, 2016-08-17 22:35:33]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 22:36:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 23:22:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 23:22:12]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-08-19 17:17:00]

rouslan@chromium.org changed reviewers:
+ estade@chromium.org

[please use gerrit instead, 2016-08-19 17:17:01]

Evan, ptal.

[please use gerrit instead, 2016-08-19 17:17:45]

rouslan@chromium.org changed reviewers:
+ tedchoc@chromium.org

[please use gerrit instead, 2016-08-19 17:17:45]

Ted, ptal credit_card_scanner_view_android.cc.

[Ted C, 2016-08-19 20:57:10]

On 2016/08/19 17:17:45, rouslan wrote:
> Ted, ptal credit_card_scanner_view_android.cc.

credit_card_scanner_view_android.cc - lgtm

[Evan Stade, 2016-08-22 21:31:56]

https://codereview.chromium.org/2257493004/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_experiments.h (right):

https://codereview.chromium.org/2257493004/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_experiments.h:25: extern const
base::Feature kAutofillScanCardHolderName;
nit: Cardholder

(I see some places that use card_holder/CardHolder and some that use
cardholder/Cardholder, but I would prefer standardizing on the latter which I'm
pretty sure is the most common spelling for issuers to use.)

[Evan Stade, 2016-08-22 21:32:00]

lgtm

[please use gerrit instead, 2016-08-22 21:51:10]

Sending to cq.

Also disabling by default at request of OCR team.

https://codereview.chromium.org/2257493004/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_experiments.h (right):

https://codereview.chromium.org/2257493004/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_experiments.h:25: extern const
base::Feature kAutofillScanCardHolderName;
On 2016/08/22 21:31:56, Evan Stade wrote:
> nit: Cardholder
> 
> (I see some places that use card_holder/CardHolder and some that use
> cardholder/Cardholder, but I would prefer standardizing on the latter which
I'm
> pretty sure is the most common spelling for issuers to use.)

Done.

[please use gerrit instead, 2016-08-22 21:51:46]

Description was changed from

==========
Add "AutofillScanNameOnCard" feature.

Add a feature named "AutofillScanNameOnCard", which is enabled by
default.

BUG=637896
==========

to

==========
Add "AutofillScanCardholderName" feature.

Add a feature named "AutofillScanCardholderName", which is disabled by
default.

BUG=637896
==========

[please use gerrit instead, 2016-08-22 21:54:52]

Description was changed from

==========
Add "AutofillScanCardholderName" feature.

Add a feature named "AutofillScanCardholderName", which is disabled by
default.

BUG=637896
==========

to

==========
Add "AutofillScanCardholderName" feature.

Add a feature named "AutofillScanCardholderName", which is disabled by
default.

BUG=637896
==========

[please use gerrit instead, 2016-08-22 21:55:01]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-08-22 21:55:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2257493004/#ps40001
(title: "Disable feature by default")

[commit-bot: I haz the power, 2016-08-22 21:55:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 23:59:20]

Description was changed from

==========
Add "AutofillScanCardholderName" feature.

Add a feature named "AutofillScanCardholderName", which is disabled by
default.

BUG=637896
==========

to

==========
Add "AutofillScanCardholderName" feature.

Add a feature named "AutofillScanCardholderName", which is disabled by
default.

BUG=637896
==========

[commit-bot: I haz the power, 2016-08-22 23:59:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-23 00:01:29]

Description was changed from

==========
Add "AutofillScanCardholderName" feature.

Add a feature named "AutofillScanCardholderName", which is disabled by
default.

BUG=637896
==========

to

==========
Add "AutofillScanCardholderName" feature.

Add a feature named "AutofillScanCardholderName", which is disabled by
default.

BUG=637896

Committed: https://crrev.com/9f59eaa1f8d3822d765edbb8d8d982f34a1e7026
Cr-Commit-Position: refs/heads/master@{#413588}
==========

[commit-bot: I haz the power, 2016-08-23 00:01:30]

Patchset 3 (id:??) landed as
https://crrev.com/9f59eaa1f8d3822d765edbb8d8d982f34a1e7026
Cr-Commit-Position: refs/heads/master@{#413588}