Better pack fields in Variable

Better pack fields in Variable
Used a BitField to for Variable fields instead of relying on the compiler, saving some memory probably.
This reduces sizeof(Variable) from 64 to 40 on x64

BUG=v8:5209
Committed: https://crrev.com/955606506c256ea389d6c4a8e07babfea512d190
Committed: https://crrev.com/57ce7d674ceea0c75b0feabc9079412759137a6f
Cr-Original-Commit-Position: refs/heads/master@{#38891}
Cr-Commit-Position: refs/heads/master@{#38967}

[heimbuef, 2016-08-17 15:41:42]

heimbuef@google.com changed reviewers:
+ verwaest@chromium.org

[heimbuef, 2016-08-17 15:42:55]

Description was changed from

==========
Better pack fields in Variable
Used a BitField to for Variable fields instead of relying on the compiler,
saving some memory probably.
This reduces sizeof(Variable) from 64 to 40 on x64

BUG=v8:5209

Committed: https://crrev.com/d84343568047c8621a6b8f88f20a7f34586321b8
Cr-Commit-Position: refs/heads/master@{#38659}

patch from issue 2253513002 at patchset 1 (http://crrev.com/2253513002#ps1)

Added static assert to BitField to ensure the contents fit within the field
==========

to

==========
Better pack fields in Variable
Used a BitField to for Variable fields instead of relying on the compiler,
saving some memory probably.
This reduces sizeof(Variable) from 64 to 40 on x64

BUG=v8:5209
==========

[heimbuef, 2016-08-17 15:49:04]

Patchset #1 (id:1) has been deleted

[Toon Verwaest, 2016-08-17 19:57:01]

lgtm

[heimbuef, 2016-08-18 07:35:02]

The CQ bit was checked by heimbuef@google.com

[heimbuef, 2016-08-18 07:35:03]

The CQ bit was unchecked by heimbuef@google.com

[heimbuef, 2016-08-18 07:36:44]

The CQ bit was checked by heimbuef@google.com

[commit-bot: I haz the power, 2016-08-18 07:36:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 08:49:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 08:49:51]

Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/12646)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[Toon Verwaest, 2016-08-23 09:50:31]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-08-23 09:50:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 09:51:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 09:51:51]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/7448)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22341)

[heimbuef, 2016-08-25 08:20:21]

The CQ bit was checked by heimbuef@google.com

[heimbuef, 2016-08-25 08:20:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2257493002/#ps40001
(title: "Merged master")

[commit-bot: I haz the power, 2016-08-25 08:20:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 08:46:11]

Description was changed from

==========
Better pack fields in Variable
Used a BitField to for Variable fields instead of relying on the compiler,
saving some memory probably.
This reduces sizeof(Variable) from 64 to 40 on x64

BUG=v8:5209
==========

to

==========
Better pack fields in Variable
Used a BitField to for Variable fields instead of relying on the compiler,
saving some memory probably.
This reduces sizeof(Variable) from 64 to 40 on x64

BUG=v8:5209
==========

[commit-bot: I haz the power, 2016-08-25 08:46:13]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-25 08:46:23]

Description was changed from

==========
Better pack fields in Variable
Used a BitField to for Variable fields instead of relying on the compiler,
saving some memory probably.
This reduces sizeof(Variable) from 64 to 40 on x64

BUG=v8:5209
==========

to

==========
Better pack fields in Variable
Used a BitField to for Variable fields instead of relying on the compiler,
saving some memory probably.
This reduces sizeof(Variable) from 64 to 40 on x64

BUG=v8:5209

Committed: https://crrev.com/955606506c256ea389d6c4a8e07babfea512d190
Cr-Commit-Position: refs/heads/master@{#38891}
==========

[commit-bot: I haz the power, 2016-08-25 08:46:26]

Patchset 2 (id:??) landed as
https://crrev.com/955606506c256ea389d6c4a8e07babfea512d190
Cr-Commit-Position: refs/heads/master@{#38891}

[neis, 2016-08-25 08:57:20]

neis@chromium.org changed reviewers:
+ neis@chromium.org

[neis, 2016-08-25 08:57:20]

https://codereview.chromium.org/2257493002/diff/40001/src/ast/variables.h
File src/ast/variables.h (right):

https://codereview.chromium.org/2257493002/diff/40001/src/ast/variables.h#new...
src/ast/variables.h:52: bit_field_ =
ForceContextAllocationField::update(bit_field_, true);
Was the DCHECK removed by accident?

[heimbuef, 2016-08-25 09:17:16]

Description was changed from

==========
Better pack fields in Variable
Used a BitField to for Variable fields instead of relying on the compiler,
saving some memory probably.
This reduces sizeof(Variable) from 64 to 40 on x64

BUG=v8:5209

Committed: https://crrev.com/955606506c256ea389d6c4a8e07babfea512d190
Cr-Commit-Position: refs/heads/master@{#38891}
==========

to

==========
Better pack fields in Variable
Used a BitField to for Variable fields instead of relying on the compiler,
saving some memory probably.
This reduces sizeof(Variable) from 64 to 40 on x64

BUG=v8:5209

Committed: https://crrev.com/955606506c256ea389d6c4a8e07babfea512d190
Cr-Commit-Position: refs/heads/master@{#38891}
==========

[heimbuef, 2016-08-25 09:18:39]

heimbuef@google.com changed reviewers:
- verwaest@chromium.org

[heimbuef, 2016-08-25 09:18:40]

PTAL

[neis, 2016-08-25 09:21:07]

lgtm, thanks.

It's possible you need to create a new CL, not sure.

[heimbuef, 2016-08-25 11:13:51]

The CQ bit was checked by heimbuef@google.com

[heimbuef, 2016-08-25 11:13:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2257493002/#ps60001
(title: "Restored DCheck")

[commit-bot: I haz the power, 2016-08-25 11:14:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 11:17:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 11:17:13]

Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/7656)

[heimbuef, 2016-08-29 07:22:07]

The CQ bit was checked by heimbuef@google.com

[heimbuef, 2016-08-29 07:22:07]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org,
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2257493002/#ps80001
(title: "Merged master (again)")

[commit-bot: I haz the power, 2016-08-29 07:22:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 07:44:24]

Description was changed from

==========
Better pack fields in Variable
Used a BitField to for Variable fields instead of relying on the compiler,
saving some memory probably.
This reduces sizeof(Variable) from 64 to 40 on x64

BUG=v8:5209

Committed: https://crrev.com/955606506c256ea389d6c4a8e07babfea512d190
Cr-Commit-Position: refs/heads/master@{#38891}
==========

to

==========
Better pack fields in Variable
Used a BitField to for Variable fields instead of relying on the compiler,
saving some memory probably.
This reduces sizeof(Variable) from 64 to 40 on x64

BUG=v8:5209

Committed: https://crrev.com/955606506c256ea389d6c4a8e07babfea512d190
Cr-Commit-Position: refs/heads/master@{#38891}
==========

[commit-bot: I haz the power, 2016-08-29 07:44:28]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-08-29 07:45:00]

Description was changed from

==========
Better pack fields in Variable
Used a BitField to for Variable fields instead of relying on the compiler,
saving some memory probably.
This reduces sizeof(Variable) from 64 to 40 on x64

BUG=v8:5209

Committed: https://crrev.com/955606506c256ea389d6c4a8e07babfea512d190
Cr-Commit-Position: refs/heads/master@{#38891}
==========

to

==========
Better pack fields in Variable
Used a BitField to for Variable fields instead of relying on the compiler,
saving some memory probably.
This reduces sizeof(Variable) from 64 to 40 on x64

BUG=v8:5209

Committed: https://crrev.com/955606506c256ea389d6c4a8e07babfea512d190
Committed: https://crrev.com/57ce7d674ceea0c75b0feabc9079412759137a6f
Cr-Original-Commit-Position: refs/heads/master@{#38891}
Cr-Commit-Position: refs/heads/master@{#38967}
==========

[commit-bot: I haz the power, 2016-08-29 07:45:01]

Patchset 4 (id:??) landed as
https://crrev.com/57ce7d674ceea0c75b0feabc9079412759137a6f
Cr-Commit-Position: refs/heads/master@{#38967}