Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2257483002: Remove more references to FileBasedSource (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -20 lines) Patch
M pkg/analyzer/benchmark/errors_in_all_libraries.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/example/resolver_driver.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 5 chunks +49 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/in_summary_source_test.dart View 2 chunks +19 lines, -12 lines 2 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
https://codereview.chromium.org/2257483002/diff/1/pkg/analyzer/test/src/summary/in_summary_source_test.dart File pkg/analyzer/test/src/summary/in_summary_source_test.dart (right): https://codereview.chromium.org/2257483002/diff/1/pkg/analyzer/test/src/summary/in_summary_source_test.dart#newcode37 pkg/analyzer/test/src/summary/in_summary_source_test.dart:37: expect(source, isNotNull); Is there a reason why we were ...
4 years, 4 months ago (2016-08-17 15:11:52 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2257483002/diff/1/pkg/analyzer/test/src/summary/in_summary_source_test.dart File pkg/analyzer/test/src/summary/in_summary_source_test.dart (right): https://codereview.chromium.org/2257483002/diff/1/pkg/analyzer/test/src/summary/in_summary_source_test.dart#newcode37 pkg/analyzer/test/src/summary/in_summary_source_test.dart:37: expect(source, isNotNull); On 2016/08/17 15:11:52, Brian Wilkerson wrote: ...
4 years, 4 months ago (2016-08-17 15:42:24 UTC) #3
Brian Wilkerson
4 years, 4 months ago (2016-08-17 16:14:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6308ab15a074321346c75dc2d9484d4423e28b14 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698