Initialize num_heap_slots_ to MIN_CONTEXT_SLOTS in SetDefaults, make already_resolved_ debug-only

Initialize num_heap_slots_ to MIN_CONTEXT_SLOTS in SetDefaults, make already_resolved_ debug-only

Variable alloction and block finalization may reset num_heap_slots_ to 0 later.

BUG=v8:5209
Committed: https://crrev.com/b12669b0e2a68422243d18adafae7efe1ab4e704
Cr-Commit-Position: refs/heads/master@{#38687}

[Toon Verwaest, 2016-08-17 14:43:54]

verwaest@chromium.org changed reviewers:
+ neis@chromium.org

[Toon Verwaest, 2016-08-17 14:43:55]

ptal

[neis, 2016-08-17 15:38:03]

lgtm

[Toon Verwaest, 2016-08-17 16:01:57]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-08-17 16:02:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 16:26:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-17 16:26:53]

Description was changed from

==========
Initialize num_heap_slots_ to MIN_CONTEXT_SLOTS in SetDefaults, make
already_resolved_ debug-only

Variable alloction and block finalization may reset num_heap_slots_ to 0 later.

BUG=v8:5209
==========

to

==========
Initialize num_heap_slots_ to MIN_CONTEXT_SLOTS in SetDefaults, make
already_resolved_ debug-only

Variable alloction and block finalization may reset num_heap_slots_ to 0 later.

BUG=v8:5209

Committed: https://crrev.com/b12669b0e2a68422243d18adafae7efe1ab4e704
Cr-Commit-Position: refs/heads/master@{#38687}
==========

[commit-bot: I haz the power, 2016-08-17 16:26:54]

Patchset 1 (id:??) landed as
https://crrev.com/b12669b0e2a68422243d18adafae7efe1ab4e704
Cr-Commit-Position: refs/heads/master@{#38687}

[ortuno, 2016-08-19 02:20:54]

ortuno@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2016-08-19 02:20:54]

https://codereview.chromium.org/2257473002/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2257473002/diff/1/src/ast/scopes.cc#newcode540
src/ast/scopes.cc:540: DCHECK(!already_resolved_);
This line is causing a crash in Debug builds. Is it a known issue?

[neis, 2016-08-19 05:54:47]

On 2016/08/19 02:20:54, ortuno wrote:
> https://codereview.chromium.org/2257473002/diff/1/src/ast/scopes.cc
> File src/ast/scopes.cc (right):
> 
> https://codereview.chromium.org/2257473002/diff/1/src/ast/scopes.cc#newcode540
> src/ast/scopes.cc:540: DCHECK(!already_resolved_);
> This line is causing a crash in Debug builds. Is it a known issue?

I don't think so. Can you tell us how to reproduce this? Thanks!

[ortuno, 2016-08-19 17:12:41]

On 2016/08/19 at 05:54:47, neis wrote:
> On 2016/08/19 02:20:54, ortuno wrote:
> > https://codereview.chromium.org/2257473002/diff/1/src/ast/scopes.cc
> > File src/ast/scopes.cc (right):
> > 
> >
https://codereview.chromium.org/2257473002/diff/1/src/ast/scopes.cc#newcode540
> > src/ast/scopes.cc:540: DCHECK(!already_resolved_);
> > This line is causing a crash in Debug builds. Is it a known issue?
> 
> I don't think so. Can you tell us how to reproduce this? Thanks!

Seems like the problem is now fixed on ToT. Thanks!