Add recipe for v8

Add recipe for v8

BUG=none
R=dpranke@chromium.org,machenbach@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=268466

[Michael Achenbach, 2014-04-04 14:11:54]

lgtm with comments:

https://codereview.chromium.org/225743005/diff/1/recipes/v8.py
File recipes/v8.py (right):

https://codereview.chromium.org/225743005/diff/1/recipes/v8.py#newcode1
recipes/v8.py:1: # Copyright (c) 2013 The Chromium Authors. All rights reserved.
nit: 2014

https://codereview.chromium.org/225743005/diff/1/recipes/v8.py#newcode17
recipes/v8.py:17: url = 'git://github.com/v8/v8.git'
Could we also make that work with the googlesource mirror?

https://codereview.chromium.org/225743005/diff/1/recipes/v8.py#newcode29
recipes/v8.py:29: 'initial_branch': 'bleeding_edge',
Can't say much about this. Will you work on 'master' after the fetch?

[jochen (gone - plz use gerrit), 2014-04-04 15:58:05]

https://codereview.chromium.org/225743005/diff/1/recipes/v8.py
File recipes/v8.py (right):

https://codereview.chromium.org/225743005/diff/1/recipes/v8.py#newcode17
recipes/v8.py:17: url = 'git://github.com/v8/v8.git'
On 2014/04/04 14:11:55, Michael Achenbach wrote:
> Could we also make that work with the googlesource mirror?

I guess so, but this is the official mirror according to code.google.com/p/v8

https://codereview.chromium.org/225743005/diff/1/recipes/v8.py#newcode29
recipes/v8.py:29: 'initial_branch': 'bleeding_edge',
On 2014/04/04 14:11:55, Michael Achenbach wrote:
> Can't say much about this. Will you work on 'master' after the fetch?

No, bleeding edge will be the default. Without this option, gclient checks out
master which doesn't make much sense for development

[Dirk Pranke, 2014-04-04 23:19:42]

It also strikes me as odd that we would want to pull from github instead of
googlesource by default; if you wanted to use fetch on a infra-managed bot, we
definitely *don't* want to do that.

I would note that this is a "fetch" recipe, not a "buildbot" recipe.

Also, check your upload to see if you need to re-upload w/ --no-find-copies ; it
looks like the patch is a bit confused.

Otherwise lgtm, but I'd want either Michael or Aaron to sign off on the github
thing.

[agable, 2014-04-04 23:59:34]

It woudl be better from an infrastructure perspective to use googlesource.

https://codereview.chromium.org/225743005/diff/20001/recipes/v8.py
File recipes/v8.py (right):

https://codereview.chromium.org/225743005/diff/20001/recipes/v8.py#newcode17
recipes/v8.py:17: url = 'git://github.com/v8/v8.git'
IIRC, gclient can handle urls of the form
host/path/to/repo.git@<arbitrary git ref>

Why not just do that, and have the url be
git://github.com/v8/v8.git@bleeding_edge
?

[jochen (gone - plz use gerrit), 2014-04-05 18:19:05]

i'm fine with using googlesource - but maybe we should also update the official
v8 docs then?

[jochen (gone - plz use gerrit), 2014-04-24 07:50:36]

I modified fetch.py so it can use a different svn prefix than origin/ and can
pass --with_branch_heads to gclient

I updated gclient so it checks out a non-master branch if specified on the
initial clone

And the v8 recipe now uses the (broken :( - http://crbug.com/366521)
googlesource server

PTAL

[Michael Achenbach, 2014-04-25 11:33:00]

lgtm

[agable, 2014-05-05 20:09:18]

On 2014/04/25 11:33:00, Michael Achenbach wrote:
> lgtm

LGTM now that all prereqs are out of the way.

[jochen (gone - plz use gerrit), 2014-05-06 08:30:36]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2014-05-06 08:30:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jochen@chromium.org/225743005/60001

[commit-bot: I haz the power, 2014-05-06 08:32:42]

Change committed as 268466