Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 225743002: Update tests to use the new compilation API. (Closed)

Created:
6 years, 8 months ago by marja
Modified:
6 years, 8 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Update tests to use the new compilation API + related fixes. Esp. get rid of PreCompile in tests, as it's going to be removed. Notes: - The new compilation API doesn't have a separate precompilation phase, so there is no separate way to check for errors except checking the compilation errors. Removed some tests which don't make sense any more. - test-api/Regress31661 didn't make sense as a regression test even before the compilation API changes, because Blink doesn't precompile this short scripts. So detecting this kind of errors (see crbug.com/31661 for more information) cannot rely on precompilation errors. - test-parsing/PreParserStrictOctal has nothing to do with PreParser, and the comment about "forcing preparsing" was just wrong. - test-api/PreCompile was supposed to test that "pre-compilation (aka preparsing) can be called without initializing the whole VM"; that's no longer true, since there's no separate precompilation step in the new compile API. There are other tests (test-parsing/DontRegressPreParserDataSizes) which ensure that we produce cached data. - Updated tests which test preparsing to use PreParser directly (not via the preparsing API). - In the new compilation API, the user doesn't need to deal with ScriptData ever. It's only used internally, and needed in tests that test internal aspects (e.g., modify the cached data before passing it back). - Some tests which used to test preparse + parse now test first time parse + second time parse, and had to be modified to ensure we don't hit the compilation cache. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20511

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -238 lines) Patch
M src/parser.h View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +6 lines, -12 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 chunks +43 lines, -70 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 10 chunks +84 lines, -111 lines 0 comments Download
M tools/parser-shell.cc View 5 chunks +30 lines, -45 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
ulan, ptal
6 years, 8 months ago (2014-04-04 11:41:25 UTC) #1
ulan
lgtm https://codereview.chromium.org/225743002/diff/40001/src/parser.h File src/parser.h (right): https://codereview.chromium.org/225743002/diff/40001/src/parser.h#newcode120 src/parser.h:120: if (functions_size < 0) return 0; Shouldn't these ...
6 years, 8 months ago (2014-04-04 12:10:59 UTC) #2
marja
thanks for review! https://codereview.chromium.org/225743002/diff/40001/src/parser.h File src/parser.h (right): https://codereview.chromium.org/225743002/diff/40001/src/parser.h#newcode120 src/parser.h:120: if (functions_size < 0) return 0; ...
6 years, 8 months ago (2014-04-04 12:13:17 UTC) #3
marja
6 years, 8 months ago (2014-04-04 12:36:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r20511 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698