|
|
DescriptionReorganized sfntly build targets.
- Split sfntly target into smaller pieces
- Add option to build sfntly sample programs
- Add new OWNERS
Committed: https://crrev.com/83db57815bc84d57d03aa2b2d99d14c00426454f
Cr-Commit-Position: refs/heads/master@{#413609}
Patch Set 1 #Patch Set 2 : No empty static_library #Patch Set 3 : Flip build_sfntly_samples to false #Patch Set 4 : add halcanary #Patch Set 5 : add jshin #Messages
Total messages: 29 (17 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thestig@chromium.org changed reviewers: + behdad@chromium.org, vandebo@chromium.org
behdad: WDYT? halcanary: Wanna be in OWNERS? vandebo: OWNERS stamp
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/08/20 06:25:24, Lei Zhang wrote: > behdad: WDYT? > halcanary: Wanna be in OWNERS? > vandebo: OWNERS stamp OWNERS LGTM
On 2016/08/20 06:25:24, Lei Zhang wrote: > halcanary: Wanna be in OWNERS? Sure. LGTM Am I the only caller of this code?
On 2016/08/22 14:41:52, Hal Canary wrote: > Am I the only caller of this code? should `sfntly_chromium` depend on `sfntly` instead of vice versa? (you would have to change skia/BUILD.gn)
On 2016/08/22 14:41:52, Hal Canary wrote: > On 2016/08/20 06:25:24, Lei Zhang wrote: > > halcanary: Wanna be in OWNERS? > > Sure. LGTM Ok, will add you to OWNERS. > Am I the only caller of this code? AFAICT, yes.
On 2016/08/22 14:54:10, Hal Canary wrote: > On 2016/08/22 14:41:52, Hal Canary wrote: > > Am I the only caller of this code? > > should `sfntly_chromium` depend on `sfntly` instead of vice versa? (you would > have to change skia/BUILD.gn) Meh. I don't think it's that confusing. I mostly wanted to break the sfntly target apart because the sfntly_chromium files are in src/cpp/src/sample/chromium, which should not be needed for all the sfntly sample targets.
On 2016/08/22 14:41:52, Hal Canary wrote: > On 2016/08/20 06:25:24, Lei Zhang wrote: > > halcanary: Wanna be in OWNERS? > > Sure. LGTM Added you in patch set 4. Waiting for behdad.
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
thestig@chromium.org changed reviewers: + halcanary@google.com, jshin@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thestig@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vandebo@chromium.org, halcanary@google.com Link to the patchset: https://codereview.chromium.org/2257423004/#ps80001 (title: "add jshin")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Reorganized sfntly build targets. - Split sfntly target into smaller pieces - Add option to build sfntly sample programs - Add new OWNERS ========== to ========== Reorganized sfntly build targets. - Split sfntly target into smaller pieces - Add option to build sfntly sample programs - Add new OWNERS Committed: https://crrev.com/83db57815bc84d57d03aa2b2d99d14c00426454f Cr-Commit-Position: refs/heads/master@{#413609} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/83db57815bc84d57d03aa2b2d99d14c00426454f Cr-Commit-Position: refs/heads/master@{#413609} |