Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1638)

Issue 2257423004: Reorganized sfntly build targets. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
CC:
chromium-reviews, arthurhsu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reorganized sfntly build targets. - Split sfntly target into smaller pieces - Add option to build sfntly sample programs - Add new OWNERS Committed: https://crrev.com/83db57815bc84d57d03aa2b2d99d14c00426454f Cr-Commit-Position: refs/heads/master@{#413609}

Patch Set 1 #

Patch Set 2 : No empty static_library #

Patch Set 3 : Flip build_sfntly_samples to false #

Patch Set 4 : add halcanary #

Patch Set 5 : add jshin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -4 lines) Patch
M third_party/sfntly/BUILD.gn View 1 2 3 chunks +138 lines, -4 lines 0 comments Download
M third_party/sfntly/OWNERS View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (17 generated)
Lei Zhang
behdad: WDYT? halcanary: Wanna be in OWNERS? vandebo: OWNERS stamp
4 years, 4 months ago (2016-08-20 06:25:24 UTC) #8
vandebo (ex-Chrome)
On 2016/08/20 06:25:24, Lei Zhang wrote: > behdad: WDYT? > halcanary: Wanna be in OWNERS? ...
4 years, 4 months ago (2016-08-21 17:39:40 UTC) #11
hal.canary
On 2016/08/20 06:25:24, Lei Zhang wrote: > halcanary: Wanna be in OWNERS? Sure. LGTM Am ...
4 years, 4 months ago (2016-08-22 14:41:52 UTC) #12
hal.canary
On 2016/08/22 14:41:52, Hal Canary wrote: > Am I the only caller of this code? ...
4 years, 4 months ago (2016-08-22 14:54:10 UTC) #13
Lei Zhang
On 2016/08/22 14:41:52, Hal Canary wrote: > On 2016/08/20 06:25:24, Lei Zhang wrote: > > ...
4 years, 4 months ago (2016-08-22 17:50:27 UTC) #14
Lei Zhang
On 2016/08/22 14:54:10, Hal Canary wrote: > On 2016/08/22 14:41:52, Hal Canary wrote: > > ...
4 years, 4 months ago (2016-08-22 17:53:09 UTC) #15
Lei Zhang
On 2016/08/22 14:41:52, Hal Canary wrote: > On 2016/08/20 06:25:24, Lei Zhang wrote: > > ...
4 years, 4 months ago (2016-08-22 18:51:44 UTC) #16
Lei Zhang
4 years, 4 months ago (2016-08-22 21:35:11 UTC) #19
jungshik at Google
LGTM
4 years, 4 months ago (2016-08-22 21:44:40 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257423004/80001
4 years, 4 months ago (2016-08-23 00:36:22 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-23 00:43:06 UTC) #27
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 00:45:15 UTC) #29
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/83db57815bc84d57d03aa2b2d99d14c00426454f
Cr-Commit-Position: refs/heads/master@{#413609}

Powered by Google App Engine
This is Rietveld 408576698