Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2257423002: Some assert fixes for running the Fuzzer sample in GPU mode. (Closed)

Created:
4 years, 4 months ago by Stephen White
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Some assert fixes for running the Fuzzer sample in GPU mode. quadraticPointCount, cubicPointCount: passing NaN to GrNextPow2 causes it to assert, so detect that and return the max points per curve instead. Passing a zero scale to GrStyle::applyToPath() makes it assert, so draw nothing (likely what drawing with a zero scale is going to do anyway). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2257423002 Committed: https://skia.googlesource.com/skia/+/b6a40b83f36b905cf85e2e3dcd88d6423938b505

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/gpu/GrBlurUtils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrPathUtils.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Stephen White
Brian: PTAL. Thanks!
4 years, 4 months ago (2016-08-19 14:45:28 UTC) #5
bsalomon
lgtm
4 years, 4 months ago (2016-08-19 14:52:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257423002/1
4 years, 4 months ago (2016-08-19 15:06:29 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 15:07:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b6a40b83f36b905cf85e2e3dcd88d6423938b505

Powered by Google App Engine
This is Rietveld 408576698