Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 22574002: Fix exitcode handling from analyzer running in nobatch mode. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 25868)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -965,7 +965,11 @@
}
if (errors.length == 0) {
- if (!hasFatalTypeErrors && exitCode != 0) {
+ // If the analyzer has warnings it will exit 1.
+ // We should reconsider how we do this once we have landed a dart
+ // only version of the analyzer for stable use (as in not run in batch
+ // mode).
+ if (!hasFatalTypeErrors && exitCode != 0 && staticWarnings.length == 0) {
diagnostics.add("EXIT CODE MISMATCH: Expected error message:");
diagnostics.add(" command[0]:${testCase.commands[0]}");
diagnostics.add(" exitCode:${exitCode}");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698