chrome/browser/component_updater/supervised_user_whitelist_installer.cc - Issue 2257363002: Define EnabledComponentUpdates group policy for the component updater.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/supervised_user_whitelist_installer.cc

Issue 2257363002: Define EnabledComponentUpdates group policy for the component updater. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@callback

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/component_updater_prefs.cc ('k') | chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc » ('j') | components/policy/resources/policy_templates.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/supervised_user_whitelist_installer.cc

diff --git a/chrome/browser/component_updater/supervised_user_whitelist_installer.cc b/chrome/browser/component_updater/supervised_user_whitelist_installer.cc

index ef24cd25d1b07b876c31ea0f6964c52e7761c766..6290a74cf5353fad43ef2baeae4300601d8c01c9 100644

--- a/chrome/browser/component_updater/supervised_user_whitelist_installer.cc

+++ b/chrome/browser/component_updater/supervised_user_whitelist_installer.cc

@@ -642,8 +642,8 @@ std::vector<uint8_t> SupervisedUserWhitelistInstaller::GetHashFromCrxId(

void SupervisedUserWhitelistInstaller::TriggerComponentUpdate(

OnDemandUpdater* updater,

const std::string& crx_id) {

- const bool result = updater->OnDemandUpdate(crx_id);

- DCHECK(result);

+ // TODO(sorin): use a callback to check the result (crbug.com/639189).

+ updater->OnDemandUpdate(crx_id, ComponentUpdateService::CompletionCallback());

}

} // namespace component_updater