Check thread is attached when creating a Persistent

Check thread is attached when creating a Persistent

BUG=591606
Committed: https://crrev.com/33f9e3a0fb535159cbd009663b9f194fc27f4205
Cr-Commit-Position: refs/heads/master@{#413125}

[keishi, 2016-08-19 04:45:01]

Description was changed from

==========
Fix Persistent check

BUG=
==========

to

==========
Check thread is attached when creating a Persistent

BUG=591606
==========

[keishi, 2016-08-19 04:48:48]

keishi@chromium.org changed reviewers:
+ haraken@chromium.org, oilpan-reviews@chromium.org

[keishi, 2016-08-19 04:48:49]

Continued from:
https://codereview.chromium.org/2208673002/#msg28

I was wrong about HeapTest. Persistent can also be initialized from memset, so
that's why I was seeing assertion failure. We can assert that
ThreadState:current() exists when creating Persistent. This adds the same checks
as Member.

[keishi, 2016-08-19 05:14:58]

The CQ bit was checked by keishi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 05:15:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-08-19 06:31:31]

https://codereview.chromium.org/2257333003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/heap/Persistent.h (right):

https://codereview.chromium.org/2257333003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/heap/Persistent.h:255: if
(m_creationThreadState) {

Maybe would it be worth distinguishing the two cases?

1) m_creationThreadState was not set because the constructor was not called.

2) m_creationThreadState was set to nullptr because this is a
CrossThreadPersistent.

To distinguish the two cases, you can set a value other than nullptr for the
case 2).

[keishi, 2016-08-19 12:23:52]

Patchset #3 (id:40001) has been deleted

[keishi, 2016-08-19 12:24:41]

The CQ bit was checked by keishi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 12:25:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[keishi, 2016-08-19 12:27:59]

On 2016/08/19 06:31:31, haraken wrote:
>
https://codereview.chromium.org/2257333003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/heap/Persistent.h (right):
> 
>
https://codereview.chromium.org/2257333003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/heap/Persistent.h:255: if
> (m_creationThreadState) {
> 
> Maybe would it be worth distinguishing the two cases?
> 
> 1) m_creationThreadState was not set because the constructor was not called.
> 
> 2) m_creationThreadState was set to nullptr because this is a
> CrossThreadPersistent.
> 
> To distinguish the two cases, you can set a value other than nullptr for the
> case 2).

I tried it but CrossThreadPersistent can also be initialized with memset so 1)
and 2) can mix, making assigning a different value meaningless.

[commit-bot: I haz the power, 2016-08-19 12:29:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 12:29:07]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-08-19 12:34:17]

On 2016/08/19 12:27:59, keishi wrote:
> On 2016/08/19 06:31:31, haraken wrote:
> >
>
https://codereview.chromium.org/2257333003/diff/20001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/platform/heap/Persistent.h (right):
> > 
> >
>
https://codereview.chromium.org/2257333003/diff/20001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/platform/heap/Persistent.h:255: if
> > (m_creationThreadState) {
> > 
> > Maybe would it be worth distinguishing the two cases?
> > 
> > 1) m_creationThreadState was not set because the constructor was not called.
> > 
> > 2) m_creationThreadState was set to nullptr because this is a
> > CrossThreadPersistent.
> > 
> > To distinguish the two cases, you can set a value other than nullptr for the
> > case 2).
> 
> I tried it but CrossThreadPersistent can also be initialized with memset so 1)
> and 2) can mix, making assigning a different value meaningless.

Thanks, makes sense. LGTM.

[keishi, 2016-08-19 13:27:03]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2016-08-19 13:27:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 13:30:40]

Description was changed from

==========
Check thread is attached when creating a Persistent

BUG=591606
==========

to

==========
Check thread is attached when creating a Persistent

BUG=591606
==========

[commit-bot: I haz the power, 2016-08-19 13:30:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-19 13:34:25]

Description was changed from

==========
Check thread is attached when creating a Persistent

BUG=591606
==========

to

==========
Check thread is attached when creating a Persistent

BUG=591606

Committed: https://crrev.com/33f9e3a0fb535159cbd009663b9f194fc27f4205
Cr-Commit-Position: refs/heads/master@{#413125}
==========

[commit-bot: I haz the power, 2016-08-19 13:34:26]

Patchset 2 (id:??) landed as
https://crrev.com/33f9e3a0fb535159cbd009663b9f194fc27f4205
Cr-Commit-Position: refs/heads/master@{#413125}