Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2257333002: Revert of Roll clang 277962:278861 (Closed)

Created:
4 years, 4 months ago by hans
Modified:
4 years, 4 months ago
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, Reid Kleckner, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, dmikurube+clang_chromium.org, inferno
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll clang 277962:278861 (patchset #6 id:100001 of https://codereview.chromium.org/2241413003/ ) Reason for revert: This broke the build on a certain Mac builder: https://build.chromium.org/p/chromium/builders/Mac/builds/18669 It looks like the build is timing out maybe? All other Mac builders seem happy though, which makes this confusing, but the buildbot logs very clearly implicate the roll: the same kind of error happened last time it landed, and it went away on the previous revert. Original issue's description: > Roll clang 277962:278861 > > BUG=636558, 637866 > > Committed: https://crrev.com/df7510f96322254211068a52c2b459c0fe0b2090 > Cr-Commit-Position: refs/heads/master@{#412943} TBR=rnk@chromium.org,dcheng@chromium.org,dpranke@chromium.org,inferno@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=636558, 637866 Committed: https://crrev.com/b557e12b23a45aaff07428fc164934020e10c4ff Cr-Commit-Position: refs/heads/master@{#412999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M base/threading/thread_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +6 lines, -3 lines 0 comments Download
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
hans
Created Revert of Roll clang 277962:278861
4 years, 4 months ago (2016-08-19 01:22:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257333002/1
4 years, 4 months ago (2016-08-19 01:23:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 01:24:28 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b557e12b23a45aaff07428fc164934020e10c4ff Cr-Commit-Position: refs/heads/master@{#412999}
4 years, 4 months ago (2016-08-19 01:29:14 UTC) #7
Dirk Pranke
4 years, 4 months ago (2016-08-19 20:49:01 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698