cc/base/contiguous_container.h - Issue 2257323002: Disable CFI on a few src/cc methods for perf reasons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/base/contiguous_container.h

Issue 2257323002: Disable CFI on a few src/cc methods for perf reasons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/base/contiguous_container.h

diff --git a/cc/base/contiguous_container.h b/cc/base/contiguous_container.h

index 2d877a16adc60e96a78d8fac937dd3e48333da9e..c876508cff0ba20dba1a6aad811d25595c8265c1 100644

--- a/cc/base/contiguous_container.h

+++ b/cc/base/contiguous_container.h

@@ -130,6 +130,7 @@ class ContiguousContainer : public ContiguousContainerBase {

ContiguousContainer(size_t max_object_size, size_t initial_size_bytes)

: ContiguousContainerBase(Align(max_object_size), initial_size_bytes) {}

+ DISABLE_CFI_PERF

danakj 2016/08/26 22:18:12 One question tho I didn't understand, why is this

krasin1 2016/08/26 22:27:42 Replied as a top-level comment (sorry)

~ContiguousContainer() {

for (auto& element : *this) {

// MSVC incorrectly reports this variable as unused.

« no previous file with comments | « base/compiler_specific.h ('k') | cc/blink/web_layer_impl.cc » ('j') | no next file with comments »