Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2257313002: Reordering FXTEXT_CHARPOS (Closed)

Created:
4 years, 4 months ago by npm
Modified:
4 years, 4 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Apply structure packing to FXTEXT_CHARPOS to save space. BUG=pdfium:562 Committed: https://pdfium.googlesource.com/pdfium/+/fb606f2723b87a145a9ceece6cd6ccaaf15ceadd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M core/fxge/include/cfx_renderdevice.h View 1 chunk +4 lines, -4 lines 0 comments Download
M core/fxge/skia/fx_skia_device_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
npm
PTAL (I hope this is what you had in mind.)
4 years, 4 months ago (2016-08-18 23:04:32 UTC) #5
Tom Sepez
lgtm Yes, as long as neither is FX_BOOL and they are both next to each ...
4 years, 4 months ago (2016-08-19 17:25:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257313002/1
4 years, 4 months ago (2016-08-19 17:25:45 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 17:26:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/fb606f2723b87a145a9ceece6cd6ccaaf15c...

Powered by Google App Engine
This is Rietveld 408576698