Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 22573004: Fixed DoMulI to adopt correct operand size when the representation is Smi (Closed)

Created:
7 years, 4 months ago by weiliang.lin2
Modified:
7 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@master
Visibility:
Public.

Description

Fixed DoMulI to adopt correct operand size when the representation is Smi BUG=

Patch Set 1 #

Patch Set 2 : add regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -20 lines) Patch
M src/runtime.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 4 chunks +24 lines, -6 lines 0 comments Download
A + test/mjsunit/smi-mul.js View 1 1 chunk +32 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
weiliang.lin2
7 years, 4 months ago (2013-08-08 10:04:45 UTC) #1
Sven Panne
Looking at the CL, this seems to be a correctness fix. Our current test suite ...
7 years, 4 months ago (2013-08-08 10:35:07 UTC) #2
weiliang.lin2
On 2013/08/08 10:35:07, Sven Panne wrote: > Looking at the CL, this seems to be ...
7 years, 4 months ago (2013-08-08 15:05:29 UTC) #3
weiliang.lin2
7 years, 4 months ago (2013-08-09 03:47:24 UTC) #4
On 2013/08/08 15:05:29, weiliang.lin2 wrote:
> On 2013/08/08 10:35:07, Sven Panne wrote:
> > Looking at the CL, this seems to be a correctness fix. Our current test
suite
> > doesn't show any error, so please add a regression test exercising all code
> > paths in DoMulI you've changed. It's probably more work than the fix itself,
> but
> > it's very important to get better coverage.
> 
> There are two reasons why our current test suite doesn't show any error. The
> first is as you said, maybe, current test cases don't cover all paths. The
> second is that Smi representation is intentionally converted to Int 32 in HMul
> instruction. I am not sure the reason. I submit a separate patch to try to
> remove this intention code. Please see
> https://codereview.chromium.org/22600005/. 
> 
> And I will work to add new regression test to exercise all code paths soon.
> 
> Thanks~

Add regression test. Pass of the test depends on
https://codereview.chromium.org/22600005/

Powered by Google App Engine
This is Rietveld 408576698