Issue 225723004: Deprecate Context::HasOutOfMemoryException.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 225723004: Deprecate Context::HasOutOfMemoryException. (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
dcarney, Paweł Hajdan Jr.

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Deprecate Context::HasOutOfMemoryException. R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20539

Patch Set 2 : deprecate instead of remove #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	include/v8.h	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Drive-by with a question. https://codereview.chromium.org/225723004/diff/1/include/v8.h File include/v8.h (left): https://codereview.chromium.org/225723004/diff/1/include/v8.h#oldcode5278 include/v8.h:5278: bool HasOutOfMemoryException() { return false; ...

6 years, 8 months ago (2014-04-07 10:26:45 UTC) #3

Yang

6 years, 8 months ago (2014-04-07 11:11:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r20539 (presubmit successful).

Expand Messages | Collapse Messages

Issue 225723004: Deprecate Context::HasOutOfMemoryException. (Closed)

Description

Patch Set 1 #

Patch Set 2 : deprecate instead of remove #

Messages