src/utils/SkCanvasStateUtils.cpp - Issue 2257203002: make LayerIter private, and remove skipClip option

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/SkCanvasStateUtils.cpp

Issue 2257203002: make LayerIter private, and remove skipClip option (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: remove related dead code Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/SkCanvasStateUtils.cpp

diff --git a/src/utils/SkCanvasStateUtils.cpp b/src/utils/SkCanvasStateUtils.cpp

index 462636ead9fb593463991973aee6a0a53a7d943d..6a519ab5aa6af717d5bf51bd35ab4a6d61451368 100644

--- a/src/utils/SkCanvasStateUtils.cpp

+++ b/src/utils/SkCanvasStateUtils.cpp

@@ -222,7 +222,7 @@ SkCanvasState* SkCanvasStateUtils::CaptureCanvasState(SkCanvas* canvas) {

SkSWriter32<3*sizeof(SkCanvasLayerState)> layerWriter;

int layerCount = 0;

- for (SkCanvas::LayerIter layer(canvas, true/*skipEmptyClips*/); !layer.done(); layer.next()) {

+ for (SkCanvas::LayerIter layer(canvas/*, true skipEmptyClips*/); !layer.done(); layer.next()) {

f(malita) 2016/08/18 18:29:31 We can get rid of this for good now.

reed1 2016/08/18 19:18:21 Done.

// we currently only work for bitmap backed devices

SkPixmap pmap;

« no previous file with comments | « src/core/SkCanvas.cpp ('k') | tests/CanvasTest.cpp » ('j') | no next file with comments »