Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1831)

Unified Diff: gin/v8_isolate_memory_dump_provider.cc

Issue 2257173003: [tools/perf] Add CodeAndMetadata metrics to v8_browsing benchmarks and add Ignition variants (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/benchmarks/v8_browsing.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/v8_isolate_memory_dump_provider.cc
diff --git a/gin/v8_isolate_memory_dump_provider.cc b/gin/v8_isolate_memory_dump_provider.cc
index fe8f4ce26c6d531a6a9f7b3b025775274b60abfa..b2d8b63e4175c4a71a229b55a287fcedefc184c5 100644
--- a/gin/v8_isolate_memory_dump_provider.cc
+++ b/gin/v8_isolate_memory_dump_provider.cc
@@ -180,6 +180,9 @@ void V8IsolateMemoryDumpProvider::DumpHeapStatistics(
auto* heap_spaces_dump =
process_memory_dump->CreateAllocatorDump(space_name_prefix);
+ // Dump statistics related to code and bytecode if requested.
+ DumpCodeStatistics(heap_spaces_dump, isolate_holder_);
+
// Dump object statistics only for detailed dumps.
if (args.level_of_detail !=
base::trace_event::MemoryDumpLevelOfDetail::DETAILED) {
@@ -230,9 +233,6 @@ void V8IsolateMemoryDumpProvider::DumpHeapStatistics(
process_memory_dump->CreateAllocatorDump(object_name_prefix)->guid(),
heap_spaces_dump->guid());
}
-
- // Dump statistics related to code and bytecode if requested.
- DumpCodeStatistics(heap_spaces_dump, isolate_holder_);
}
} // namespace gin
« no previous file with comments | « no previous file | tools/perf/benchmarks/v8_browsing.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698