Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2257143002: [interpreter] Fix self-healing with preserved bytecode. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fix self-healing with preserved bytecode. This fixes the self-healing mechanism for closures in the interpreter entry trampoline not that bytecode can be preserved even when baseline code is already available. R=rmcilroy@chromium.org TEST=cctest/test-compiler/IgnitionEntryTrampolineSelfHealing BUG=chromium:638225 Committed: https://crrev.com/4598d9139e5930543b55bca2154afc966b64c557 Cr-Commit-Position: refs/heads/master@{#38747}

Patch Set 1 #

Patch Set 2 : Added ports and test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -47 lines) Patch
M src/builtins/arm/builtins-arm.cc View 1 2 chunks +10 lines, -8 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 2 chunks +10 lines, -8 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 2 chunks +10 lines, -8 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 2 chunks +10 lines, -7 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 2 chunks +10 lines, -7 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 2 chunks +10 lines, -8 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 2 chunks +35 lines, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
Michael Starzinger
Only for a single architecture so far, but I wanted to get your take on ...
4 years, 4 months ago (2016-08-18 12:51:49 UTC) #3
rmcilroy
Approach looks good, thanks.
4 years, 4 months ago (2016-08-18 13:03:50 UTC) #4
Michael Starzinger
Added architecture ports and a test case. This should be ready for prime time. PTAL.
4 years, 4 months ago (2016-08-18 14:20:41 UTC) #10
rmcilroy
LGTM, thanks.
4 years, 4 months ago (2016-08-19 10:08:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257143002/20001
4 years, 4 months ago (2016-08-19 10:32:12 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-19 10:34:11 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 10:34:33 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4598d9139e5930543b55bca2154afc966b64c557
Cr-Commit-Position: refs/heads/master@{#38747}

Powered by Google App Engine
This is Rietveld 408576698