Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 2257133002: Revert of There are only 2 language modes, not 3 (Closed)

Created:
4 years, 4 months ago by Michael Hablich
Modified:
4 years, 4 months ago
Reviewers:
neis, Toon Verwaest, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of There are only 2 language modes, not 3 (patchset #4 id:60001 of https://codereview.chromium.org/2250703003/ ) Reason for revert: Breaks ARM and MIPS builds e.g. https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20builder/builds/2479/steps/compile/logs/stdio Original issue's description: > There are only 2 language modes, not 3 > > BUG= > > Committed: https://crrev.com/39764ba293412adde99a77a66d0750695312e006 > Cr-Commit-Position: refs/heads/master@{#38704} TBR=neis@chromium.org,marja@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/8fd0ce04e50225ce18adf65395101a3ebfd247c9 Cr-Commit-Position: refs/heads/master@{#38714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -20 lines) Patch
M src/ast/scopes.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/globals.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/ic-state.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/objects.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Michael Hablich
Created Revert of There are only 2 language modes, not 3
4 years, 4 months ago (2016-08-18 12:02:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257133002/1
4 years, 4 months ago (2016-08-18 12:02:40 UTC) #3
commit-bot: I haz the power
Failed to apply patch for src/ast/scopes.h: While running git apply --index -3 -p1; error: patch ...
4 years, 4 months ago (2016-08-18 12:02:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257133002/1
4 years, 4 months ago (2016-08-18 12:05:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 12:06:08 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 12:06:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fd0ce04e50225ce18adf65395101a3ebfd247c9
Cr-Commit-Position: refs/heads/master@{#38714}

Powered by Google App Engine
This is Rietveld 408576698