Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2257123003: recipe_autoroller: always set cwd to workdir (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

recipe_autoroller: always set cwd to workdir TBR=emso,sergiyb,tandrii BUG=620494 Committed: https://chromium.googlesource.com/infra/infra/+/e880323f0a199434c071cc107f8f0f4823b6b5d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M recipes/recipe_modules/recipe_autoroller/api.py View 1 chunk +3 lines, -2 lines 0 comments Download
M recipes/recipes/recipe_autoroller.expected/basic.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/recipes/recipe_autoroller.expected/empty.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/recipes/recipe_autoroller.expected/failed_upload.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/recipes/recipe_autoroller.expected/failure.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/recipes/recipe_autoroller.expected/nontrivial.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/recipes/recipe_autoroller.expected/previously_uploaded.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/recipes/recipe_autoroller.expected/previously_uploaded_match.json View 2 chunks +2 lines, -0 lines 0 comments Download
M recipes/recipes/recipe_autoroller.expected/repo_data_nontrivial_open.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/recipes/recipe_autoroller.expected/repo_data_trivial_closed.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/recipes/recipe_autoroller.expected/repo_data_trivial_cq.json View 1 chunk +1 line, -0 lines 0 comments Download
M recipes/recipes/recipe_autoroller.expected/with_auth.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257123003/1
4 years, 4 months ago (2016-08-18 12:31:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/e880323f0a199434c071cc107f8f0f4823b6b5d4
4 years, 4 months ago (2016-08-18 12:58:41 UTC) #5
Paweł Hajdan Jr.
TBR
4 years, 4 months ago (2016-08-18 13:24:04 UTC) #7
Sergiy Byelozyorov
It looks like you add cwd to the context in this CL and pass it ...
4 years, 3 months ago (2016-08-31 10:53:39 UTC) #8
Paweł Hajdan Jr.
On 2016/08/31 at 10:53:39, sergiyb wrote: > It looks like you add cwd to the ...
4 years, 3 months ago (2016-08-31 11:00:46 UTC) #9
Sergiy Byelozyorov
4 years, 3 months ago (2016-08-31 11:02:08 UTC) #10
Message was sent while issue was closed.
Thanks. I'm going to LGTM this CL and the other one, but investigate why the
expectations did not change.

Powered by Google App Engine
This is Rietveld 408576698