chrome/browser/extensions/api/feedback_private/feedback_private_api.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection_manager.cc ('k') | chrome/browser/extensions/api/file_system/file_system_api.cc » ('j') | chrome/browser/extensions/api/omnibox/omnibox_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

index 8ab8fa907c54c8a008fa06c3fdfebb808eaf96c2..9ab0045ecba9ac5d68ae9df00ec06179c23cfccf 100644

--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

@@ -121,8 +121,8 @@ void FeedbackPrivateAPI::RequestFeedbackForFlow(

if (browser_context_ && EventRouter::Get(browser_context_)) {

FeedbackInfo info;

info.description = description_template;

- info.category_tag = base::WrapUnique(new std::string(category_tag));

- info.page_url = base::WrapUnique(new std::string(page_url.spec()));

+ info.category_tag = base::MakeUnique<std::string>(category_tag);

+ info.page_url = base::MakeUnique<std::string>(page_url.spec());

info.system_information.reset(new SystemInformationList);

// The manager is only available if tracing is enabled.

if (TracingManager* manager = TracingManager::Get()) {