SkTDynamicHash: support remove() without needing Deleted().

SkTDynamicHash
  - add validate()
  - make add() and remove() strict
  - fill in maybeShrink()
  - make grow and shrink thresholds configurable.
  - fix issue where we were getting filled with deleted items - we need to count them as occupied when determining if we should grow

BUG=
R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10677

[reed1, 2013-08-07 18:10:32]

lgtm w/ nits

https://codereview.chromium.org/22571010/diff/1/src/core/SkTDynamicHash.h
File src/core/SkTDynamicHash.h (right):

https://codereview.chromium.org/22571010/diff/1/src/core/SkTDynamicHash.h#new...
src/core/SkTDynamicHash.h:37: if (candidate == NULL) {
nit: NULL == candidate

https://codereview.chromium.org/22571010/diff/1/src/core/SkTDynamicHash.h#new...
src/core/SkTDynamicHash.h:56: if (candidate == NULL) {
see prev. nit

https://codereview.chromium.org/22571010/diff/1/src/core/SkTDynamicHash.h#new...
src/core/SkTDynamicHash.h:85: if (candidate == NULL || Equal(*candidate, key)) {
again with the nits

https://codereview.chromium.org/22571010/diff/1/src/core/SkTDynamicHash.h#new...
src/core/SkTDynamicHash.h:105: if (candidate == NULL) {
not again?

[mtklein, 2013-08-07 18:15:29]

On 2013/08/07 18:10:32, reed1 wrote:
> lgtm w/ nits
> 
> https://codereview.chromium.org/22571010/diff/1/src/core/SkTDynamicHash.h
> File src/core/SkTDynamicHash.h (right):
> 
>
https://codereview.chromium.org/22571010/diff/1/src/core/SkTDynamicHash.h#new...
> src/core/SkTDynamicHash.h:37: if (candidate == NULL) {
> nit: NULL == candidate
> 
>
https://codereview.chromium.org/22571010/diff/1/src/core/SkTDynamicHash.h#new...
> src/core/SkTDynamicHash.h:56: if (candidate == NULL) {
> see prev. nit
> 
>
https://codereview.chromium.org/22571010/diff/1/src/core/SkTDynamicHash.h#new...
> src/core/SkTDynamicHash.h:85: if (candidate == NULL || Equal(*candidate, key))
{
> again with the nits
> 
>
https://codereview.chromium.org/22571010/diff/1/src/core/SkTDynamicHash.h#new...
> src/core/SkTDynamicHash.h:105: if (candidate == NULL) {
> not again?

all done.

[commit-bot: I haz the power, 2013-08-07 18:16:25]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@google.com/22571010/6001

[mtklein, 2013-08-08 19:55:02]

On 2013/08/07 18:16:25, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://skia-tree-status.appspot.com/cq/mtklein%40google.com/22571010/6001

Updated this CL to be "fix everything that turned out to be wrong when trying to
remove the need for Deleted(), which is not possible".

[mtklein, 2013-08-12 14:51:29]

Committed patchset #4 manually as r10677.