Plumb drawArc to SkDevice

src/core/SkCanvas.cpp

Index: src/core/SkCanvas.cpp
diff --git a/src/core/SkCanvas.cpp b/src/core/SkCanvas.cpp
index 539fd36028ac214dad18d49df808b34b6a187ea9..f5c1174bbda26d6c580bf31a14adec1108f10613 100644
--- a/src/core/SkCanvas.cpp
+++ b/src/core/SkCanvas.cpp
@@ -2273,6 +2273,29 @@ void SkCanvas::onDrawOval(const SkRect& oval, const SkPaint& paint) {
     LOOPER_END
 }
 
+void SkCanvas::onDrawArc(const SkRect& oval, SkScalar startAngle,
+                         SkScalar sweepAngle, bool useCenter,
+                         const SkPaint& paint) {

[robertphillips, 2016/08/19 16:13:52]

drawArc -> onDrawArc ?

[bsalomon, 2016/08/19 16:37:03]

None of the other onDrawFoo methods use "on".

+    TRACE_EVENT0("disabled-by-default-skia", "SkCanvas::drawArc()");
+    SkRect storage;
+    const SkRect* bounds = nullptr;
+    if (paint.canComputeFastBounds()) {

[robertphillips, 2016/08/19 16:13:52]

Can storage be moved here ?

[bsalomon, 2016/08/19 16:37:03]

Done.

+        // Note we're using the entire oval as the bounds.
+        if (this->quickReject(paint.computeFastBounds(oval, &storage))) {
+            return;
+        }
+        bounds = &oval;
+    }
+
+    LOOPER_BEGIN(paint, SkDrawFilter::kArc_Type, bounds)
+
+    while (iter.next()) {
+        iter.fDevice->drawArc(iter, oval, startAngle, sweepAngle, useCenter, looper.paint());
+    }
+
+    LOOPER_END
+}
+
 void SkCanvas::onDrawRRect(const SkRRect& rrect, const SkPaint& paint) {
     TRACE_EVENT0("disabled-by-default-skia", "SkCanvas::drawRRect()");
     SkRect storage;
@@ -3081,15 +3104,7 @@ void SkCanvas::drawArc(const SkRect& oval, SkScalar startAngle,
     if (SkScalarAbs(sweepAngle) >= SkIntToScalar(360)) {
         this->drawOval(oval, paint);
     } else {
-        SkPath  path;
-        if (useCenter) {
-            path.moveTo(oval.centerX(), oval.centerY());
-        }
-        path.arcTo(oval, startAngle, sweepAngle, !useCenter);
-        if (useCenter) {
-            path.close();
-        }
-        this->drawPath(path, paint);
+        this->onDrawArc(oval, startAngle, sweepAngle, useCenter, paint);
     }
 }