Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2257023002: Replace uses of FileBasedSource in cli (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -50 lines) Patch
M pkg/analyzer/lib/src/generated/source_io.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 6 chunks +68 lines, -24 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 15 chunks +28 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-18 02:41:20 UTC) #2
scheglov
LGTM
4 years, 4 months ago (2016-08-18 02:46:36 UTC) #3
Brian Wilkerson
4 years, 4 months ago (2016-08-18 13:11:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a9cafd85c9b1e22e19e8a0acb97a2d78e05d1be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698