chrome/common/extensions/api/app.json - Issue 2257003002: [Extensions] Generate all schema resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/app.json

Issue 2257003002: [Extensions] Generate all schema resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ready Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/json_schema_api.gni ('K') | « chrome/common/BUILD.gn ('k') | chrome/common/extensions/api/declarative_content.json » ('j') | chrome/common/extensions/chrome_extensions_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/app.json

diff --git a/chrome/common/extensions/api/app.json b/chrome/common/extensions/api/app.json

index c4ad21fbcfb8a0854786f67c2ac00306afc0529b..b05495c8a6384893941b549cf16a26212e7ff9c3 100644

--- a/chrome/common/extensions/api/app.json

+++ b/chrome/common/extensions/api/app.json

@@ -19,6 +19,16 @@

"type": "object",

"properties": {},

"additionalProperties": { "type": "any" }

+ },

+ {

+ "id": "InstallState",

+ "type": "string",

+ "enum": ["not_installed", "installed", "disabled"]

+ },

+ {

+ "id": "RunningState",

+ "type": "string",

+ "enum": ["running", "cannot_run", "ready_to_run"]

}

"functions": [

@@ -43,9 +53,8 @@

"name": "callback",

"parameters": [

{

- "type": "string",

- "name": "state",

- "enum": [ "not_installed", "installed", "disabled" ]

+ "$ref": "InstallState",

+ "name": "state"

}

]

}

@@ -57,8 +66,7 @@

"type": "function",

"parameters": [],

"returns": {

- "type": "string",

- "enum": [ "running", "cannot_run", "ready_to_run" ]

+ "$ref": "RunningState"

}

{

« build/json_schema_api.gni ('K') | « chrome/common/BUILD.gn ('k') | chrome/common/extensions/api/declarative_content.json » ('j') | chrome/common/extensions/chrome_extensions_client.cc » ('J')