Check Content Window Visibility in DesktopNativeWidgetAura::IsVisible

Check Content Window Visibility in DesktopNativeWidgetAura::IsVisible

Since DesktopNativeWidgetAura shows both the window tree host and the
content window in DesktopNativeWidgetAura::Show, it stands to reason
that DesktopNativeWidgetAura::IsVisible should also check both for
visibility.

Because Windows may show the Chrome window on its own before
BrowserView::Show is called, BrowserView::Show will assume everything
has been shown and just activate the window, failing to show the
content window. Adding in a content window visibility check provides
the actual visibility state of the window, even if it is intermediate.

BUG=638748
Committed: https://crrev.com/cbaec91aacdd72f3f2941ff3f7b7706100d5081e
Cr-Commit-Position: refs/heads/master@{#412949}

[robliao, 2016-08-18 00:55:26]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 00:56:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 02:09:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 02:09:30]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-08-18 17:00:44]

robliao@chromium.org changed reviewers:
+ sky@chromium.org

[robliao, 2016-08-18 17:00:45]

sky: Please review this CL. Thanks!

[sky, 2016-08-18 19:18:40]

Great description! This is subtle and worth both a comment and test. Can you add
test coverage?

[robliao, 2016-08-18 19:53:16]

Patchset #2 (id:20001) has been deleted

[robliao, 2016-08-18 19:53:29]

On 2016/08/18 19:18:40, sky wrote:
> Great description! This is subtle and worth both a comment and test. Can you
add
> test coverage?

Good catch on the test. Done and done.

[robliao, 2016-08-18 19:53:34]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 19:54:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 21:43:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 21:43:51]

Dry run: This issue passed the CQ dry run.

[sky, 2016-08-18 21:57:47]

LGTM

[robliao, 2016-08-18 21:58:20]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2016-08-18 21:59:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 22:08:00]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-18 22:14:02]

Description was changed from

==========
Check Content Window Visibility in DesktopNativeWidgetAura::IsVisible

Since DesktopNativeWidgetAura shows both the window tree host and the
content window in DesktopNativeWidgetAura::Show, it stands to reason
that DesktopNativeWidgetAura::IsVisible should also check both for
visibility.

Because Windows may show the Chrome window on its own before
BrowserView::Show is called, BrowserView::Show will assume everything
has been shown and just activate the window, failing to show the
content window. Adding in a content window visibility check provides
the actual visibility state of the window, even if it is intermediate.

BUG=638748
==========

to

==========
Check Content Window Visibility in DesktopNativeWidgetAura::IsVisible

Since DesktopNativeWidgetAura shows both the window tree host and the
content window in DesktopNativeWidgetAura::Show, it stands to reason
that DesktopNativeWidgetAura::IsVisible should also check both for
visibility.

Because Windows may show the Chrome window on its own before
BrowserView::Show is called, BrowserView::Show will assume everything
has been shown and just activate the window, failing to show the
content window. Adding in a content window visibility check provides
the actual visibility state of the window, even if it is intermediate.

BUG=638748

Committed: https://crrev.com/cbaec91aacdd72f3f2941ff3f7b7706100d5081e
Cr-Commit-Position: refs/heads/master@{#412949}
==========

[commit-bot: I haz the power, 2016-08-18 22:14:03]

Patchset 2 (id:??) landed as
https://crrev.com/cbaec91aacdd72f3f2941ff3f7b7706100d5081e
Cr-Commit-Position: refs/heads/master@{#412949}