Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2256983002: Temporary fix for OOM in precompilation with very large methods. (Closed)

Created:
4 years, 4 months ago by Florian Schneider
Modified:
4 years, 4 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Temporary fix for OOM in precompilation with very large methods. Bail out of load/store optimizations for very large methods because of quadratic space usage. BUG=#27087 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/bfa70e6df2a64f6f17240ba0bc295cd24a83c7ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M runtime/vm/flag_list.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/redundancy_elimination.cc View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Florian Schneider
4 years, 4 months ago (2016-08-18 00:32:58 UTC) #2
rmacnak
lgtm
4 years, 4 months ago (2016-08-18 16:27:20 UTC) #3
siva
Do we know why the memory consumption is so high?
4 years, 4 months ago (2016-08-18 16:34:42 UTC) #5
Florian Schneider
4 years, 4 months ago (2016-08-18 17:10:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bfa70e6df2a64f6f17240ba0bc295cd24a83c7ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698