Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2256963003: MIPS: Implement Neg_d and Neg_s instruction macros. (Closed)

Created:
4 years, 4 months ago by Marija Antic
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Implement Neg_d and Neg_s instruction macros. Implement Neg_d and Neg_s in macro-assembler. Floating point negate instructions are removed in release 6. On r2, these instructoin do not change the sign of NaN operands. TEST=cctest/test-run-wasm/RunWasmCompiled_Float32Neg, cctest/test-run-wasm/RunWasmCompiled_Float64Neg BUG= Committed: https://crrev.com/e1c5d09bdac3302153e7c8427928dfbd5d4dd80a Cr-Commit-Position: refs/heads/master@{#38749}

Patch Set 1 #

Patch Set 2 : Fix a typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -14 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +61 lines, -1 line 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +56 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Marija Antic
PTAL
4 years, 4 months ago (2016-08-18 09:56:40 UTC) #2
akos.palfi.imgtec
LGTM
4 years, 4 months ago (2016-08-19 10:16:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256963003/20001
4 years, 4 months ago (2016-08-19 11:30:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-19 11:32:25 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 11:32:39 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1c5d09bdac3302153e7c8427928dfbd5d4dd80a
Cr-Commit-Position: refs/heads/master@{#38749}

Powered by Google App Engine
This is Rietveld 408576698