Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2256963002: Settings People: Prevent long profile names from clobbering buttons. (Closed)

Created:
4 years, 4 months ago by tommycli
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings People: Prevent long profile names from clobbering buttons. BUG=603466 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/566aabfccaef722eeb0cd45c0b078ee9e99e5441 Cr-Commit-Position: refs/heads/master@{#412851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
tommycli
dbeam: PTAL After & before: http://imgur.com/a/vAbtT Don't laugh at the pic, it's a real bug. ...
4 years, 4 months ago (2016-08-17 23:55:32 UTC) #4
Dan Beam
lgtm
4 years, 4 months ago (2016-08-18 02:01:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256963002/1
4 years, 4 months ago (2016-08-18 15:31:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 16:31:21 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 16:34:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/566aabfccaef722eeb0cd45c0b078ee9e99e5441
Cr-Commit-Position: refs/heads/master@{#412851}

Powered by Google App Engine
This is Rietveld 408576698